From: Joonyoung Shim <jy0922.shim@samsung.com>
To: klimov.linux@gmail.com
Cc: linux-media@vger.kernel.org, tobias.lorenz@gmx.net,
kyungmin.park@samsung.com
Subject: Re: About the radio-si470x driver for I2C interface
Date: Thu, 02 Apr 2009 10:42:35 +0900 [thread overview]
Message-ID: <49D4180B.4040805@samsung.com> (raw)
In-Reply-To: <4e1455be0904011754l2c51cf2fi6336d07d591cbb71@mail.gmail.com>
> Hello
>
> On Tue, Mar 10, 2009 at 3:20 AM, Mauro Carvalho Chehab
> <mchehab@infradead.org> wrote:
>> On Mon, 9 Mar 2009 23:33:38 +0100
>> Tobias Lorenz <tobias.lorenz@gmx.net> wrote:
>>
>>> Hi,
>>>
>>>> The proper way is to break radio-si470x into two parts:
>>>>
>>>> - A i2c adapter driver (similar to what we have on cx88-i2c, for
>>>> example, plus the radio part of cx88-video);
>>>> - A radio driver (similar to tea5767.c).
>>>>
>>>> This way, the i2c driver can be used on designs that use a different i2c adapter.
>>> yes, this is why I already capsulated most of the USB functionality into own functions. I awaited that somewhen the si470x is used in the "usual" way by i2c.
>>>
>>> I'm not sure, if we should split the driver into three files (generic/common, usb, i2c) or just implement the new functionality within the same file using macros/defines.
>> It is better to split. It will provide more flexibility.
>
> Tobias, Joonyoung
>
> Is there any success on this ?
Hi,
I have tried, but could not do it yet.
Like radio-tea5764.c, radio-si470x driver for I2C interface also was
implemented as the I2C driver, but it has many redundant functions with
the existing radio-si470x for USB interface, so I tried to join two
interfaces but it was a difficult work. I have never seen the linux device
driver probing more than one interface optionally.
-- Joonyoung Shim
>
> --
> Best regards, Klimov Alexey
>
>
>
next prev parent reply other threads:[~2009-04-02 1:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 3:13 About the radio-si470x driver for I2C interface Joonyoung Shim
2009-03-06 10:46 ` Mauro Carvalho Chehab
2009-03-07 15:27 ` Problem with changeset 10837: causes "make all" not to build many modules Alain Kalker
2009-03-08 16:54 ` Mauro Carvalho Chehab
2009-03-09 2:17 ` Alain Kalker
2009-03-09 4:30 ` Mauro Carvalho Chehab
2009-03-09 13:57 ` Alain Kalker
[not found] ` <200903092333.38819.tobias.lorenz@gmx.net>
2009-03-09 23:20 ` About the radio-si470x driver for I2C interface Mauro Carvalho Chehab
2009-03-31 22:54 ` Alexey Klimov
[not found] ` <4e1455be0904011754l2c51cf2fi6336d07d591cbb71@mail.gmail.com>
2009-04-02 1:42 ` Joonyoung Shim [this message]
[not found] ` <200904122256.12305.tobias.lorenz@gmx.net>
2009-04-13 1:14 ` Alexey Klimov
2009-04-13 11:06 ` Hans Verkuil
2009-04-13 1:46 ` Joonyoung Shim
2009-04-13 5:30 ` Joonyoung Shim
[not found] ` <200904131215.05703.tobias.lorenz@gmx.net>
2009-04-13 10:31 ` Joonyoung Shim
2009-04-13 10:42 ` Joonyoung Shim
[not found] ` <200904132035.57419.tobias.lorenz@gmx.net>
2009-04-14 5:29 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D4180B.4040805@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=klimov.linux@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=tobias.lorenz@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox