Broken ioctls for the mpeg encoder on the HVR-1800

Broken ioctls for the mpeg encoder on the HVR-1800

[Joseph Yasi]

Hello,

With the cx23885 driver that shipped with 2.6.29, as well as the
latest hg driver, the analog mpeg encoder device for the HVR-1800 does
not respond to the VIDIOC_QUERYCAP ioctl, returning ENOTTY.  This
ioctl previously worked with the driver in 2.6.28.  The preview device
does respond to the ioctl properly, and I am able to tune and set the
input via the preview device.  I can also capture MPEG using a simple
cat /dev/video1 > out.mpg.  Are the ioctls supposed to work on the
mpeg device, or should it be tuned via the preview device only?

Thanks,
Joe Yasi

Re: Broken ioctls for the mpeg encoder on the HVR-1800

[Steven Toth]

Joseph Yasi wrote:
> Hello,
> 
> With the cx23885 driver that shipped with 2.6.29, as well as the
> latest hg driver, the analog mpeg encoder device for the HVR-1800 does
> not respond to the VIDIOC_QUERYCAP ioctl, returning ENOTTY.  This
> ioctl previously worked with the driver in 2.6.28.  The preview device
> does respond to the ioctl properly, and I am able to tune and set the
> input via the preview device.  I can also capture MPEG using a simple
> cat /dev/video1 > out.mpg.  Are the ioctls supposed to work on the
> mpeg device, or should it be tuned via the preview device only?

Most of the ioctls I tested were against the preview device, although some do 
work on the encoder device itself (bitrate etc).

- Steve

Re: Broken ioctls for the mpeg encoder on the HVR-1800

[Joseph Yasi]

On Thu, Apr 2, 2009 at 9:31 AM, Steven Toth <stoth@linuxtv.org> wrote:
> Most of the ioctls I tested were against the preview device, although some
> do work on the encoder device itself (bitrate etc).

Changing the bitrate doesn't work anymore either.  The video_ioctl2
hook got dropped from the cx23885-417 driver when v4l2_file_operations
was introduced in changeset d615e9cdfbdd.  Is there a reason this was
dropped?

Thanks,
Joe Yasi

diff -r 4c7466ea8d64 linux/drivers/media/video/cx23885/cx23885-417.c
--- a/linux/drivers/media/video/cx23885/cx23885-417.c   Wed Apr 01
07:36:31 2009 -0300
+++ b/linux/drivers/media/video/cx23885/cx23885-417.c   Sat Apr 04
16:33:29 2009 -0500
@@ -1683,6 +1683,7 @@
        .read          = mpeg_read,
        .poll          = mpeg_poll,
        .mmap          = mpeg_mmap,
+       .ioctl         = video_ioctl2,
 };

 static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {