linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Erik Andrén" <erik.andren@gmail.com>
To: Anders Blomdell <anders.blomdell@control.lth.se>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Thomas Kaiser <v4l@kaiser-linux.li>,
	Jean-Francois Moine <moinejf@free.fr>,
	Thomas Champagne <lafeuil@gmail.com>,
	Linux Media <linux-media@vger.kernel.org>,
	Richard Case <rich@racitup.com>
Subject: Re: topro 6800 driver
Date: Fri, 03 Apr 2009 22:54:25 +0200	[thread overview]
Message-ID: <49D67781.6030807@gmail.com> (raw)
In-Reply-To: <49D66C83.6000700@control.lth.se>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Anders Blomdell wrote:
> New version attached, handles both 640x480 and 320x240, corrected gamma table.
> 
> Seems to work OK with mplayer, vlc and https://launchpad.net/python-v4l2-capture
> 
>  vlc v4l2://dev/video0:width=320:height=240
>  vlc v4l2://dev/video0:width=640:height=480
> 
> Jean-Francois: feel free to add this to gspca if it lives up to your standards,
> otherwise tell me what needs to be changed.
> 
> Best regards
> 
> /Anders
> 
> 

Hi Anders,

Before submitting a driver, please make sure it passes the
checkpatch.pl script found in the linux/scripts/ folder.
When I checked the tp6800.c file I got about ~4300 errors.
This is due to that the file isn't using the indentation used by
code in the linux tree.

If you first run the Lindent script (found in the same folder) about
23 errors pop up that need to be corrected. Beware though that
Lindent sometimes screw up lines so manual inspection of the code is
needed.

Best regards, / hälsningar,
Erik
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknWd4EACgkQN7qBt+4UG0E8LgCfQYON+qQJS7gOjnmF8BqUuuW8
M8YAoJJroBbk2CXBS+z6qCL6ZU41EOXy
=RBZP
-----END PGP SIGNATURE-----

  reply	other threads:[~2009-04-03 20:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 18:06 topro 6800 driver Andy Shevchenko
     [not found] ` <49CD2868.9080502@kaiser-linux.li>
     [not found]   ` <5ec8ebd50903311144h316c7e3bmd30ce2c3d5a268ee@mail.gmail.com>
     [not found]     ` <49D4EAB2.4090206@control.lth.se>
2009-04-03 20:07       ` Anders Blomdell
2009-04-03 20:54         ` Erik Andrén [this message]
2009-04-04 11:29           ` Anders Blomdell
2009-04-05 17:36             ` Jean-Francois Moine
2009-04-20 15:37               ` Thomas Champagne
     [not found]       ` <5ec8ebd50904050933w660c130wd31b1d46a53884df@mail.gmail.com>
2009-04-05 18:16         ` Fwd: " Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2009-02-27 22:15 Topro " Anders Blomdell
2009-02-28 10:31 ` Jean-Francois Moine
2009-02-28 15:11   ` Anders Blomdell
2009-02-28 15:54     ` Thomas Kaiser
2009-03-01  7:26     ` Jean-Francois Moine
2009-03-01 16:33     ` Thomas Champagne
2009-03-02 13:20       ` Jean-Francois Moine
2009-03-02 16:58         ` Anders Blomdell
2009-02-28 11:54 ` Thomas Kaiser
     [not found] ` <49B194A7.4030808@kaiser-linux.li>
2009-03-09 12:10   ` Anders Blomdell
     [not found]     ` <49B50E16.8080703@kaiser-linux.li>
2009-03-09 14:06       ` Anders Blomdell
2009-03-09 18:51       ` Anders Blomdell
2009-03-09 20:10         ` Thomas Kaiser
2009-03-09 20:29           ` Anders Blomdell
2009-03-09 20:43             ` Thomas Kaiser
     [not found]               ` <49B62023.2090206@control.lth.se>
     [not found]                 ` <49B65BA7.6070700@kaiser-linux.li>
     [not found]                   ` <49B68F34.60802@control.lth.se>
     [not found]                     ` <49B6A495.9060204@kaiser-linux.li>
2009-03-11 15:09                       ` Anders Blomdell
2009-03-11 19:11                         ` Thomas Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D67781.6030807@gmail.com \
    --to=erik.andren@gmail.com \
    --cc=anders.blomdell@control.lth.se \
    --cc=andy.shevchenko@gmail.com \
    --cc=lafeuil@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=rich@racitup.com \
    --cc=v4l@kaiser-linux.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).