public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Erik Andrén" <erik.andren@gmail.com>
Cc: Adam Baker <linux@baker-net.org.uk>,
	Hans de Goede <j.w.r.degoede@hhs.nl>,
	Linux and Kernel Video <video4linux-list@redhat.com>,
	SPCA50x Linux Device Driver Development
	<spca50x-devs@lists.sourceforge.net>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: libv4l release: 0.5.97: the whitebalance release!
Date: Sun, 19 Apr 2009 09:45:41 +0200	[thread overview]
Message-ID: <49EAD6A5.1010507@redhat.com> (raw)
In-Reply-To: <49E9E652.5070706@gmail.com>



On 04/18/2009 04:40 PM, Erik Andrén wrote:
>
> Hans de Goede wrote:
>>
>> On 04/17/2009 09:27 PM, Erik Andrén wrote:
>>> Hans de Goede wrote:
>>>> On 04/16/2009 10:46 PM, Adam Baker wrote:
>>>>> On Thursday 16 Apr 2009, Hans de Goede wrote:
>>>>>> On 04/16/2009 12:26 AM, Adam Baker wrote:
>>>>>>> On Wednesday 15 Apr 2009, Hans de Goede wrote:
>>>>>>>> Currently only whitebalancing is enabled and only on Pixarts (pac)
>>>>>>>> webcams (which benefit tremendously from this). To test this with
>>>>>>>> other
>>>>>>>> webcams (after instaling this release) do:
>>>>>>>>
>>>>>>>> export LIBV4LCONTROL_CONTROLS=15
>>>>>>>> LD_PRELOAD=/usr/lib/libv4l/v4l2convert.so v4l2ucp&
>>>>>>> Strangely while those instructions give me a whitebalance control
>>>>>>> for the
>>>>>>> sq905 based camera I can't get it to appear for a pac207 based camera
>>>>>>> regardless of whether LIBV4LCONTROL_CONTROLS is set.
>>>>>> Thats weird, there is a small bug in the handling of pac207
>>>>>> cams with usb id 093a:2476 causing libv4l to not automatically
>>>>>> enable whitebalancing (and the control) for cams with that id,
>>>>>> but if you have LIBV4LCONTROL_CONTROLS set (exported!) both
>>>>>> when loading v4l2ucp (you must preload v4l2convert.so!) and
>>>>>> when loading your viewer, then it should work.
>>>>>>
>>>>> I've tested it by plugging in the sq905 camera, verifying the
>>>>> whitebablance
>>>>> control is present and working, unplugging the sq905 and plugging in
>>>>> the
>>>>> pac207 and using up arrow to restart v4l2ucp and svv so I think I've
>>>>> eliminated most finger trouble possibilities. The pac207 is id
>>>>> 093a:2460 so
>>>>> not the problem id. I'll have to investigate more thoroughly later.
>>>>>
>>>> Does the pac207 perhaps have a / in its "card" string (see v4l-info
>>>> output) ?
>>>> if so try out this patch:
>>>> http://linuxtv.org/hg/~hgoede/libv4l/rev/1e08d865690a
>>>>
>>> I have the same issue as Adam when trying to test this with my
>>> gspca_stv06xx based Quickcam Web camera i. e no whitebalancing
>>> controls show up. I'm attaching a dump which logs all available
>>> pixformats and v4l2ctrls showing that libv4l is properly loaded.
>>> (And yes, LIBV4LCONTROL_CONTROLS is exported and set to 15).
>>>
>>> Best regards,
>>> Erik
>>>
>> Ah, you are using v4l2-ctl, not v4l2ucp, and that uses
>> V4L2_CTRL_FLAG_NEXT_CTRL
>> control enumeration. My code doesn't handle V4L2_CTRL_FLAG_NEXT_CTRL
>> (which is
>> a bug). I'm not sure when I'll have time to fix this. Patches welcome,
>> or in
>> the mean time use v4l2ucp to play with the controls.
>>
>
> Actually, I've tried to use both without finding the controls.
> I've only tried with v4l2ucp v. 1.2. Is 1.3 necessary?
>

Apparently there are different versions of v4l2ucp in different distro's
and some do use the V4L2_CTRL_FLAG_NEXT_CTRL, just like v4l2-ctl. See
Adam Baker's patch later in this thread. Which I will apply to my
tree after I've reviewed it (when I find some time currently I've a lot of
$work$ )

Regards,

Hans

  reply	other threads:[~2009-04-19  7:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15 12:36 libv4l release: 0.5.97: the whitebalance release! Hans de Goede
2009-04-15 22:26 ` Adam Baker
2009-04-15 23:02   ` Hans de Goede
2009-04-16 20:46     ` Adam Baker
2009-04-17  8:54       ` Hans de Goede
2009-04-17 19:27         ` Erik Andrén
2009-04-18 11:29           ` Hans de Goede
2009-04-18 14:40             ` Erik Andrén
2009-04-19  7:45               ` Hans de Goede [this message]
2009-04-19 19:20                 ` Erik Andrén
2009-04-19 19:49                   ` Hans de Goede
2009-04-20  4:43                     ` Erik Andrén
2009-04-20  7:43                       ` Hans de Goede
2009-04-20  7:54                         ` Erik Andrén
2009-04-18 19:44             ` Adam Baker
2009-04-18 22:45               ` [PATCH][libv4l] Support V4L2_CTRL_FLAG_NEXT_CTRL for fake controls Adam Baker
2009-05-17 13:49                 ` Hans de Goede
2009-04-17 22:13         ` libv4l release: 0.5.97: the whitebalance release! Adam Baker
2009-04-18 11:27           ` Hans de Goede
2009-04-16  6:16 ` Gilles Gigan
2009-04-16  9:25   ` Hans de Goede
2009-04-16  9:38     ` Gilles Gigan
2009-04-17 19:31 ` Erik Andrén

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EAD6A5.1010507@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=erik.andren@gmail.com \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@baker-net.org.uk \
    --cc=spca50x-devs@lists.sourceforge.net \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox