From: Antti Palosaari <crope@iki.fi>
To: linux-media@vger.kernel.org
Cc: Armin Schenker <sar@snafu.de>
Subject: Re: Add Elgato EyeTV DTT deluxe to dibcom driver
Date: Sun, 19 Apr 2009 23:06:09 +0300 [thread overview]
Message-ID: <49EB8431.70202@iki.fi> (raw)
In-Reply-To: <E63C5667-D18B-4D13-9D88-15293E1B12B2@snafu.de>
Armin Schenker kirjoitti:
> - .num_device_descs = 11,
> + .num_device_descs = 12,
> - struct dvb_usb_device_description devices[11];
> + struct dvb_usb_device_description devices[12];
I don't comment about this patch but general.
I didn't realized this value is allowed to increase when adding new
devices. Due to that there is now three dvb_usb_device_properties in
af9015 which makes driver a little bit complex.
What we should do? Can I remove code from af9015 and increase
dvb_usb_device_description count to about 30? What is biggest suitable
value we want use, how much memory one entry will take.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2009-04-19 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 17:58 Add Elgato EyeTV DTT deluxe to dibcom driver Armin Schenker
2009-04-19 20:06 ` Antti Palosaari [this message]
2009-04-20 14:21 ` Patrick Boettcher
2009-04-20 14:58 ` Patrick Boettcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EB8431.70202@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=sar@snafu.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox