From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-media@vger.kernel.org, mchehab@infradead.org
Subject: Re: [PATCH 2/2] se401: Fix coding style
Date: Tue, 09 Jun 2009 17:17:38 +0300 [thread overview]
Message-ID: <4A2E6F02.6040003@teltonika.lt> (raw)
In-Reply-To: <20090609125720.10098.88218.stgit@t61.ukuu.org.uk>
Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> Having fixed the sprintfs I decided a quick clean wouldn't do any harm so
> it was actually easy to read in future.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/media/video/se401.c | 876 ++++++++++++++++++++++---------------------
> drivers/media/video/se401.h | 7
> 2 files changed, 452 insertions(+), 431 deletions(-)
>
>
> diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c
> index 08129a8..c8f0529 100644
> --- a/drivers/media/video/se401.c
> +++ b/drivers/media/video/se401.c
[...]
> @@ -78,8 +79,8 @@ static void *rvmalloc(unsigned long size)
> adr = (unsigned long) mem;
> while (size > 0) {
> SetPageReserved(vmalloc_to_page((void *)adr));
> - adr += PAGE_SIZE;
> - size -= PAGE_SIZE;
> + adr += PAGE_SIZE;
> + size -= PAGE_SIZE;
Why 2 spaces are better here?
> }
>
> return mem;
next prev parent reply other threads:[~2009-06-09 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 12:54 [PATCH 0/2] SE401 clean up Alan Cox
2009-06-09 12:56 ` [PATCH 1/2] se401: Fix unsafe use of sprintf with identical source/destination Alan Cox
2009-06-09 13:02 ` [PATCH 2/2] se401: Fix coding style Alan Cox
2009-06-09 14:17 ` Paulius Zaleckas [this message]
2009-06-09 15:05 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2E6F02.6040003@teltonika.lt \
--to=paulius.zaleckas@teltonika.lt \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox