From: Brian Johnson <brijohn@gmail.com>
To: leandro Costantino <lcostantino@gmail.com>
Cc: Jean-Francois Moine <moinejf@free.fr>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 0/2] gspca sn9c20x subdriver rev2
Date: Sat, 18 Jul 2009 23:23:50 -0400 [thread overview]
Message-ID: <4A6291C6.1090507@gmail.com> (raw)
In-Reply-To: <c2fe070d0907181345x7e8fae62rd3ba3d47f75e3dbb@mail.gmail.com>
> shouldn't there be a check when allocating jpg_hdr? or i am missing something?
>
>
> sd->jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL);
> jpeg_define(sd->jpeg_hdr, height, width, 0x21);
> jpeg_set_qual(sd->jpeg_hdr, sd->quality);
Yes probably there should be a check there. I'll one more minor
revision with this plus the changes Jean-Francois mentioned
previously in a bit.
Brian Johnson
prev parent reply other threads:[~2009-07-19 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 20:51 [PATCH 0/2] gspca sn9c20x subdriver rev2 Brian Johnson
2009-07-17 20:51 ` [PATCH 1/2] gspca: add support for v4l2 debugging ioctls Brian Johnson
2009-07-17 20:51 ` [PATCH 2/2] gspca: Add sn9c20x subdriver Brian Johnson
2009-07-18 8:35 ` [PATCH 0/2] gspca sn9c20x subdriver rev2 Jean-Francois Moine
2009-07-18 15:19 ` Brian Johnson
2009-07-18 20:45 ` leandro Costantino
2009-07-19 3:23 ` Brian Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6291C6.1090507@gmail.com \
--to=brijohn@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lcostantino@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox