From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: linux-media@vger.kernel.org, mchehab@infradead.org,
tobias.lorenz@gmx.net, kyungmin.park@samsung.com
Subject: Re: [PATCH v2 4/4] radio-si470x: add i2c driver for si470x
Date: Tue, 21 Jul 2009 14:00:29 +0900 [thread overview]
Message-ID: <4A654B6D.1070805@samsung.com> (raw)
In-Reply-To: <208cbae30907190719v3fcffee0g1f15d05da5e182f2@mail.gmail.com>
<snip>
>> +
>> +int si470x_disconnect_check(struct si470x_device *radio)
>> +{
>> + return 0;
>> +}
>
> Looks like this function is empty and it's called few times. Is it
> good to make it inline?
>
Yes, this function is empty. It looks fine to me too.
I will modify it, thanks.
next prev parent reply other threads:[~2009-07-21 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 5:15 [PATCH v2 4/4] radio-si470x: add i2c driver for si470x Joonyoung Shim
2009-07-19 14:19 ` Alexey Klimov
2009-07-21 5:00 ` Joonyoung Shim [this message]
2009-07-30 10:30 ` Tobias Lorenz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A654B6D.1070805@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=klimov.linux@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tobias.lorenz@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox