[PATCH] cx23885-417: fix setting tvnorms

[PATCH] cx23885-417: fix setting tvnorms

[Joseph Yasi]

Currently, the VIDIOC_S_STD ioctl just returns -EINVAL regardless of
the norm passed.  This patch sets cx23885_mpeg_template.tvnorms and
cx23885_mpeg_template.current_norm so that the VIDIOC_S_STD will work.

Signed-off-by: Joseph A. Yasi <joe.yasi@gmail.com>

---
diff -r ee6cf88cb5d3 linux/drivers/media/video/cx23885/cx23885-417.c
--- a/linux/drivers/media/video/cx23885/cx23885-417.c   Wed Jul 29
01:42:02 2009 -0300
+++ b/linux/drivers/media/video/cx23885/cx23885-417.c   Thu Jul 30
00:38:14 2009 -0500
@@ -1738,6 +1738,8 @@
        .fops          = &mpeg_fops,
        .ioctl_ops     = &mpeg_ioctl_ops,
        .minor         = -1,
+       .tvnorms       = CX23885_NORMS,
+       .current_norm  = V4L2_STD_NTSC_M,
 };

 void cx23885_417_unregister(struct cx23885_dev *dev)

Re: [PATCH] cx23885-417: fix setting tvnorms

[Steven Toth]

On 7/30/09 1:46 AM, Joseph Yasi wrote:
> Currently, the VIDIOC_S_STD ioctl just returns -EINVAL regardless of
> the norm passed.  This patch sets cx23885_mpeg_template.tvnorms and
> cx23885_mpeg_template.current_norm so that the VIDIOC_S_STD will work.
>
> Signed-off-by: Joseph A. Yasi<joe.yasi@gmail.com>

Joseph, thank you for raising this.

We have this change and a few others already stacked up in this tree:

http://www.kernellabs.com/hg/~mkrufky/cx23885-api/rev/0391fb200be2

The end result is to get MythTV using the HVR1800 analog encoder correctly.

The tree itself is considered experimental but during testing we had noticed the 
same issue, so, again, thank you for raising the same issue. Two people 
reporting the same issue is always better than none.

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com

Re: [PATCH] cx23885-417: fix setting tvnorms

[Michael Krufky]

On Thu, Jul 30, 2009 at 9:25 AM, Steven Toth<stoth@kernellabs.com> wrote:
> On 7/30/09 1:46 AM, Joseph Yasi wrote:
>>
>> Currently, the VIDIOC_S_STD ioctl just returns -EINVAL regardless of
>> the norm passed.  This patch sets cx23885_mpeg_template.tvnorms and
>> cx23885_mpeg_template.current_norm so that the VIDIOC_S_STD will work.
>>
>> Signed-off-by: Joseph A. Yasi<joe.yasi@gmail.com>
>
> Joseph, thank you for raising this.
>
> We have this change and a few others already stacked up in this tree:
>
> http://www.kernellabs.com/hg/~mkrufky/cx23885-api/rev/0391fb200be2
>
> The end result is to get MythTV using the HVR1800 analog encoder correctly.
>
> The tree itself is considered experimental but during testing we had noticed
> the same issue, so, again, thank you for raising the same issue. Two people
> reporting the same issue is always better than none.
>
> - Steve

I will break out this patch from the huge patch-mess in my cx23885-api
tree so that it can be merged separately from the other less-obvious
fixes.

Thanks again for pointing it out -- I'll see this fix gets merged
sooner than later ;-)

Cheers,

Mike