public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Julian Scheel <julian@jusst.de>
To: linux-media@vger.kernel.org
Subject: [PATCH] Fix lowband tuning with tda8261
Date: Fri, 31 Jul 2009 18:40:43 +0200	[thread overview]
Message-ID: <4A731E8B.4030005@jusst.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Attached is a patch which fixes tuning to low frequency channels with 
stb0899+tda8261 cards like the KNC TV-Station DVB-S2.
The cause of the issue was a broken if construct, which should have been 
an if/else if, so that the setting for the lowest matching frequency is 
applied.

Without this patch for example tuning to "arte" on Astra 19.2, 10744MHz 
SR22000 failed most times and when it failed the communication between 
driver and tda8261 was completely broken.
This problem disappears with the attached patch.

[-- Attachment #2: fix_tda8261_lowband.patch --]
[-- Type: text/plain, Size: 478 bytes --]

diff -r 6477aa1782d5 linux/drivers/media/dvb/frontends/tda8261.c
--- a/linux/drivers/media/dvb/frontends/tda8261.c	Tue Jul 21 09:17:24 2009 -0300
+++ b/linux/drivers/media/dvb/frontends/tda8261.c	Fri Jul 31 18:36:07 2009 +0200
@@ -136,9 +136,9 @@
 
 		if (frequency < 1450000)
 			buf[3] = 0x00;
-		if (frequency < 2000000)
+		else if (frequency < 2000000)
 			buf[3] = 0x40;
-		if (frequency < 2150000)
+		else if (frequency < 2150000)
 			buf[3] = 0x80;
 
 		/* Set params */

             reply	other threads:[~2009-07-31 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 16:40 Julian Scheel [this message]
2009-07-31 16:57 ` [PATCH] Fix lowband tuning with tda8261 Alex Deucher
2009-07-31 17:01   ` Julian Scheel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A731E8B.4030005@jusst.de \
    --to=julian@jusst.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox