[PATCH] Fix lowband tuning with tda8261

[PATCH] Fix lowband tuning with tda8261

[Julian Scheel]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Attached is a patch which fixes tuning to low frequency channels with 
stb0899+tda8261 cards like the KNC TV-Station DVB-S2.
The cause of the issue was a broken if construct, which should have been 
an if/else if, so that the setting for the lowest matching frequency is 
applied.

Without this patch for example tuning to "arte" on Astra 19.2, 10744MHz 
SR22000 failed most times and when it failed the communication between 
driver and tda8261 was completely broken.
This problem disappears with the attached patch.

[-- Attachment #2: fix_tda8261_lowband.patch --]
[-- Type: text/plain, Size: 478 bytes --]

diff -r 6477aa1782d5 linux/drivers/media/dvb/frontends/tda8261.c
--- a/linux/drivers/media/dvb/frontends/tda8261.c	Tue Jul 21 09:17:24 2009 -0300
+++ b/linux/drivers/media/dvb/frontends/tda8261.c	Fri Jul 31 18:36:07 2009 +0200
@@ -136,9 +136,9 @@
 
 		if (frequency < 1450000)
 			buf[3] = 0x00;
-		if (frequency < 2000000)
+		else if (frequency < 2000000)
 			buf[3] = 0x40;
-		if (frequency < 2150000)
+		else if (frequency < 2150000)
 			buf[3] = 0x80;
 
 		/* Set params */

Re: [PATCH] Fix lowband tuning with tda8261

[Alex Deucher]

On Fri, Jul 31, 2009 at 12:40 PM, Julian Scheel<julian@jusst.de> wrote:
> Attached is a patch which fixes tuning to low frequency channels with
> stb0899+tda8261 cards like the KNC TV-Station DVB-S2.
> The cause of the issue was a broken if construct, which should have been an
> if/else if, so that the setting for the lowest matching frequency is
> applied.
>
> Without this patch for example tuning to "arte" on Astra 19.2, 10744MHz
> SR22000 failed most times and when it failed the communication between
> driver and tda8261 was completely broken.
> This problem disappears with the attached patch.
>

Please replay with your Signed Off By.

Alex

> diff -r 6477aa1782d5 linux/drivers/media/dvb/frontends/tda8261.c
> --- a/linux/drivers/media/dvb/frontends/tda8261.c       Tue Jul 21 09:17:24
> 2009 -0300
> +++ b/linux/drivers/media/dvb/frontends/tda8261.c       Fri Jul 31 18:36:07
> 2009 +0200
> @@ -136,9 +136,9 @@
>
>                if (frequency < 1450000)
>                        buf[3] = 0x00;
> -               if (frequency < 2000000)
> +               else if (frequency < 2000000)
>                        buf[3] = 0x40;
> -               if (frequency < 2150000)
> +               else if (frequency < 2150000)
>                        buf[3] = 0x80;
>
>                /* Set params */
>
>

Re: [PATCH] Fix lowband tuning with tda8261

[Julian Scheel]

Alex Deucher schrieb:
> On Fri, Jul 31, 2009 at 12:40 PM, Julian Scheel<julian@jusst.de> wrote:
>   
>> Attached is a patch which fixes tuning to low frequency channels with
>> stb0899+tda8261 cards like the KNC TV-Station DVB-S2.
>> The cause of the issue was a broken if construct, which should have been an
>> if/else if, so that the setting for the lowest matching frequency is
>> applied.
>>
>> Without this patch for example tuning to "arte" on Astra 19.2, 10744MHz
>> SR22000 failed most times and when it failed the communication between
>> driver and tda8261 was completely broken.
>> This problem disappears with the attached patch.
>>
>>     
>
> Please replay with your Signed Off By.
>
> Alex
>
>   
>> diff -r 6477aa1782d5 linux/drivers/media/dvb/frontends/tda8261.c
>> --- a/linux/drivers/media/dvb/frontends/tda8261.c       Tue Jul 21 09:17:24
>> 2009 -0300
>> +++ b/linux/drivers/media/dvb/frontends/tda8261.c       Fri Jul 31 18:36:07
>> 2009 +0200
>> @@ -136,9 +136,9 @@
>>
>>                if (frequency < 1450000)
>>                        buf[3] = 0x00;
>> -               if (frequency < 2000000)
>> +               else if (frequency < 2000000)
>>                        buf[3] = 0x40;
>> -               if (frequency < 2150000)
>> +               else if (frequency < 2150000)
>>                        buf[3] = 0x80;
>>
>>                /* Set params */
>>
>>
>>     
Signed-off-by: Julian Scheel <julian@jusst.de>