public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: emagick@magic.ms
To: linux-media@vger.kernel.org
Subject: [PATCH] dvb-usb: fix tuning with Cinergy T2
Date: Sun, 02 Aug 2009 09:43:15 +0200	[thread overview]
Message-ID: <4A754393.4090502@magic.ms> (raw)
In-Reply-To: <4A733BAB.6080305@magic.ms>

Initialize param.flags.

Signed-off-by: Eberhard Mattes <eberhard.mattes@web.de>
---
Not setting param.flags was the real cause of the inability of the Cinergy T2
driver to tune under certain circumstances. Moving stuff from the stack to the
heap did not really solve the problem. As there are several other drivers which
pass buffers on the stack to the USB layer, I leave fixing that to others.
This patch is against 2.6.30.


--- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c	2009-06-10 05:05:27.000000000 +0200
+++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c	2009-08-02 09:28:55.000000000 +0200
@@ -275,6 +275,7 @@ static int cinergyt2_fe_set_frontend(str
  	param.tps = cpu_to_le16(compute_tps(fep));
  	param.freq = cpu_to_le32(fep->frequency / 1000);
  	param.bandwidth = 8 - fep->u.ofdm.bandwidth - BANDWIDTH_8_MHZ;
+	param.flags = 0;

  	err = dvb_usb_generic_rw(state->d,
  			(char *)&param, sizeof(param),


      parent reply	other threads:[~2009-08-02  7:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18 16:51 Cinergy T2 stopped working with kernel 2.6.30 emagick
2009-07-23  8:20 ` emagick
2009-07-30  9:49 ` emagick
2009-07-30 17:46 ` emagick
2009-07-31  8:39 ` emagick
2009-07-31  8:43 ` emagick
2009-07-31  8:48   ` emagick
2009-07-31 18:44 ` emagick
2009-07-31 19:37   ` emagick
2009-07-31 19:47   ` emagick
2009-07-31 19:50     ` Markus Rechberger
2009-07-31 21:31   ` Johannes Stezenbach
2009-08-02  7:43   ` emagick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A754393.4090502@magic.ms \
    --to=emagick@magic.ms \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox