From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from compulab.co.il ([67.18.134.219]:58373 "EHLO compulab.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754905AbZHCOCo (ORCPT ); Mon, 3 Aug 2009 10:02:44 -0400 Message-ID: <4A76DF29.1050008@compulab.co.il> Date: Mon, 03 Aug 2009 15:59:21 +0300 From: Mike Rapoport MIME-Version: 1.0 To: Guennadi Liakhovetski CC: Eric Miao , Marek Vasut , linux-arm-kernel@lists.arm.linux.org.uk, Russell King - ARM Linux , Linux Media Mailing List , Stefan Herbrechtsmeier Subject: Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera References: <200908031031.00676.marek.vasut@gmail.com> <4A76CB7C.10401@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Guennadi Liakhovetski wrote: > On Mon, 3 Aug 2009, Eric Miao wrote: > >> Marek Vasut wrote: >>> Hi! >>> >>> Eric, would you mind applying ? >>> >>> From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Sep 17 00:00:00 2001 >>> From: Marek Vasut >>> Date: Mon, 3 Aug 2009 10:27:57 +0200 >>> Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera >>> >>> Those formats are requiered on widely used OmniVision OV96xx cameras. >>> Those formats are nothing more then endian-swapped RGB555 and RGB565. >>> >>> Signed-off-by: Marek Vasut >> Acked-by: Eric Miao >> >> Guennadi, >> >> Would be better if this gets merged by you, thanks. > > Indeed it would, and I do have a couple of questions to this and related > patches: > > 1. Marek, you're saying, you need these formats for the OV96xx camera. Yre > you using the patch from Stefan Herbrechtsmeier to support ov96xx or some > other? > > 2. Mike, while reviewing this patch I came across code in > pxa_camera_setup_cicr(), introduced by your earlier patch: > > case V4L2_PIX_FMT_RGB555: > cicr1 |= CICR1_RGB_BPP_VAL(1) | CICR1_RGBT_CONV_VAL(2) | > CICR1_TBIT | CICR1_COLOR_SP_VAL(1); > break; > > Why are you enabling the RGB to RGBT conversion here unconditionally? > Generally, what are the advantages of configuring CICR1 for a specific RGB > format compared to using just a raw capture? Do I understand it right, > that ATM we are not using any of those features? As far as I remember I've tried to overlay the captured imagery using pxa overlay1. Most probably it's left here after those tries. > Thanks > Guennadi > >>> --- >>> drivers/media/video/pxa_camera.c | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/media/video/pxa_camera.c >>> b/drivers/media/video/pxa_camera.c >>> index 46e0d8a..de0fc8a 100644 >>> --- a/drivers/media/video/pxa_camera.c >>> +++ b/drivers/media/video/pxa_camera.c >>> @@ -1222,6 +1222,8 @@ static int required_buswidth(const struct >>> soc_camera_data_format *fmt) >>> case V4L2_PIX_FMT_YVYU: >>> case V4L2_PIX_FMT_RGB565: >>> case V4L2_PIX_FMT_RGB555: >>> + case V4L2_PIX_FMT_RGB565X: >>> + case V4L2_PIX_FMT_RGB555X: >>> return 8; >>> default: >>> return fmt->depth; >>> @@ -1260,6 +1262,8 @@ static int pxa_camera_get_formats(struct >>> soc_camera_device *icd, int idx, >>> case V4L2_PIX_FMT_YVYU: >>> case V4L2_PIX_FMT_RGB565: >>> case V4L2_PIX_FMT_RGB555: >>> + case V4L2_PIX_FMT_RGB565X: >>> + case V4L2_PIX_FMT_RGB555X: >>> formats++; >>> if (xlate) { >>> xlate->host_fmt = icd->formats + idx; > > --- > Guennadi Liakhovetski > -- Sincerely yours, Mike.