From: Antoine Jacquet <royale@zerezo.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zr364: wrong indexes
Date: Thu, 13 Aug 2009 15:47:21 +0200 [thread overview]
Message-ID: <4A841969.9050209@zerezo.com> (raw)
In-Reply-To: <4A8151A1.2020103@gmail.com>
Hi,
You are right, thanks for fixing this bug.
I have pushed your patch to my tree.
Best regards,
Antoine
Roel Kluin wrote:
> The order of indexes is reversed
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Right?
>
> diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c
> index fc976f4..2622a6e 100644
> --- a/drivers/media/video/zr364xx.c
> +++ b/drivers/media/video/zr364xx.c
> @@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file)
> for (i = 0; i < 2; i++) {
> err =
> send_control_msg(udev, 1, init[cam->method][i].value,
> - 0, init[i][cam->method].bytes,
> + 0, init[cam->method][i].bytes,
> init[cam->method][i].size);
> if (err < 0) {
> dev_err(&udev->dev, "error during release sequence\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-08-13 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 11:10 [PATCH] zr364: wrong indexes Roel Kluin
2009-08-13 13:47 ` Antoine Jacquet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A841969.9050209@zerezo.com \
--to=royale@zerezo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox