* [PATCH] zr364: wrong indexes
@ 2009-08-11 11:10 Roel Kluin
2009-08-13 13:47 ` Antoine Jacquet
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-11 11:10 UTC (permalink / raw)
To: Antoine Jacquet, linux-usb, linux-media, Andrew Morton
The order of indexes is reversed
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Right?
diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c
index fc976f4..2622a6e 100644
--- a/drivers/media/video/zr364xx.c
+++ b/drivers/media/video/zr364xx.c
@@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file)
for (i = 0; i < 2; i++) {
err =
send_control_msg(udev, 1, init[cam->method][i].value,
- 0, init[i][cam->method].bytes,
+ 0, init[cam->method][i].bytes,
init[cam->method][i].size);
if (err < 0) {
dev_err(&udev->dev, "error during release sequence\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] zr364: wrong indexes
2009-08-11 11:10 [PATCH] zr364: wrong indexes Roel Kluin
@ 2009-08-13 13:47 ` Antoine Jacquet
0 siblings, 0 replies; 2+ messages in thread
From: Antoine Jacquet @ 2009-08-13 13:47 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-usb, linux-media, Andrew Morton
Hi,
You are right, thanks for fixing this bug.
I have pushed your patch to my tree.
Best regards,
Antoine
Roel Kluin wrote:
> The order of indexes is reversed
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Right?
>
> diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c
> index fc976f4..2622a6e 100644
> --- a/drivers/media/video/zr364xx.c
> +++ b/drivers/media/video/zr364xx.c
> @@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file)
> for (i = 0; i < 2; i++) {
> err =
> send_control_msg(udev, 1, init[cam->method][i].value,
> - 0, init[i][cam->method].bytes,
> + 0, init[cam->method][i].bytes,
> init[cam->method][i].size);
> if (err < 0) {
> dev_err(&udev->dev, "error during release sequence\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-13 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-11 11:10 [PATCH] zr364: wrong indexes Roel Kluin
2009-08-13 13:47 ` Antoine Jacquet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox