From: Steven Toth <stoth@kernellabs.com>
To: Konstantin Dimitrov <kosio.dimitrov@gmail.com>
Cc: linux-media@vger.kernel.org, bob@turbosight.com
Subject: Re: [PATCH] cx23885: fix support for TBS 6920 card
Date: Thu, 20 Aug 2009 09:03:00 -0400 [thread overview]
Message-ID: <4A8D4984.4000309@kernellabs.com> (raw)
In-Reply-To: <20090819232002.a941c388.kosio.dimitrov@gmail.com>
On 8/19/09 7:20 PM, Konstantin Dimitrov wrote:
>
> fix: GPIO initialization for TBS 6920
> fix: wrong I2C address for demod on TBS 6920
> fix: wrong I2C bus number for demod on TBS 6920
> fix: wrong "gen_ctrl_val" value for TS1 port on TBS 6920 (and some other cards)
> add: module_param "lnb_pwr_ctrl" as option to choose between "type 0" and "type 1" of LNB power control (two TBS 6920 boards no matter that they are marked as the same hardware revision may have different types of LNB power control)
> fix: LNB power control function for type 0 doesn't preserve the previous GPIO state, which is critical
> add: LNB power control function for type 1
>
> Signed-off-by: Bob Liu<bob@turbosight.com>
> Signed-off-by: Konstantin Dimitrov<kosio.dimitrov@gmail.com>
I got a weird HTML related email bounce from vger when I responded originally to
this via gmail. Maybe this time via thunderbird will bring success.
...
Hmm. A custom hanging off of a gpio to something that looks like an i2c power
control device. I want to review some of these generic (and no-so-generic)
changes before we merge this patch.
Is the datasheet for the LNB power control device available to the public? I'd
like to understand some of the register details.
Thanks,
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
next prev parent reply other threads:[~2009-08-20 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 23:20 [PATCH] cx23885: fix support for TBS 6920 card Konstantin Dimitrov
2009-08-20 13:03 ` Steven Toth [this message]
2009-08-20 15:38 ` Konstantin Dimitrov
2009-08-30 23:15 ` Mauro Carvalho Chehab
2010-02-02 14:47 ` Mauro Carvalho Chehab
2010-02-02 15:12 ` Konstantin Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D4984.4000309@kernellabs.com \
--to=stoth@kernellabs.com \
--cc=bob@turbosight.com \
--cc=kosio.dimitrov@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox