* compat.h required to build
@ 2009-08-21 16:02 Lou Otway
2009-08-21 16:34 ` Andy Walls
0 siblings, 1 reply; 3+ messages in thread
From: Lou Otway @ 2009-08-21 16:02 UTC (permalink / raw)
To: linux-media
Hi,
The following files:
/linux/drivers/media/dvb/frontends/stb6100.c
/linux/drivers/media/dvb/frontends/tda10021.c
/linux/drivers/media/dvb/frontends/ves1820.c
Fail to build with:
error: implicit declaration of function 'DIV_ROUND_CLOSEST'
and need the addition of:
#include "compat.h"
when building on my system. Is this related to my kernel version
(2.6.28) or is it something else?
Thanks,
Lou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: compat.h required to build
2009-08-21 16:02 compat.h required to build Lou Otway
@ 2009-08-21 16:34 ` Andy Walls
2009-08-21 16:35 ` Devin Heitmueller
0 siblings, 1 reply; 3+ messages in thread
From: Andy Walls @ 2009-08-21 16:34 UTC (permalink / raw)
To: lotway; +Cc: linux-media
On Fri, 2009-08-21 at 17:02 +0100, Lou Otway wrote:
> Hi,
>
> The following files:
>
> /linux/drivers/media/dvb/frontends/stb6100.c
> /linux/drivers/media/dvb/frontends/tda10021.c
> /linux/drivers/media/dvb/frontends/ves1820.c
>
> Fail to build with:
>
> error: implicit declaration of function 'DIV_ROUND_CLOSEST'
>
> and need the addition of:
>
> #include "compat.h"
>
> when building on my system. Is this related to my kernel version
> (2.6.28) or is it something else?
DIV_ROUND_CLOSEST is probably available only in more recent kernels.
When its use was added to those files, backward compatability was likely
not tested. Including compat.h is the proper thing to do.
Regards,
Andy
> Thanks,
>
> Lou
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: compat.h required to build
2009-08-21 16:34 ` Andy Walls
@ 2009-08-21 16:35 ` Devin Heitmueller
0 siblings, 0 replies; 3+ messages in thread
From: Devin Heitmueller @ 2009-08-21 16:35 UTC (permalink / raw)
To: Andy Walls; +Cc: lotway, linux-media
On Fri, Aug 21, 2009 at 12:34 PM, Andy Walls<awalls@radix.net> wrote:
> DIV_ROUND_CLOSEST is probably available only in more recent kernels.
> When its use was added to those files, backward compatability was likely
> not tested. Including compat.h is the proper thing to do.
>
> Regards,
> Andy
I'm pretty sure Mauro just added the macro to compat.h yesterday (and
I can only assume he missed a couple of includes). Lou, feel free to
submit a patch with the extra includes, including an SOB.
Thanks,
Devin
--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-21 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-21 16:02 compat.h required to build Lou Otway
2009-08-21 16:34 ` Andy Walls
2009-08-21 16:35 ` Devin Heitmueller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox