public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Pablo Castellano <pablog.ubuntu@gmail.com>
To: linux-media@vger.kernel.org
Cc: mchehab@infradead.org
Subject: [PATCH] Add remote support to cph03x bttv card
Date: Sat, 22 Aug 2009 19:43:50 +0200	[thread overview]
Message-ID: <4A902E56.9000604@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Hello kernel developers.
I found a bug report from an user in launchpad. I just copy it here. It
includes patch.

I don't own the necessary hardware to test it but the patch looks trivial.

I'm not subscribed to this list, so please CC me. Thanks!

Here is the text:


"""
remote control for my tv card doesnt work

I have Askey CPH03x TV Capturer.
When I load bttv module with "card=59" option which is proper for this
tv card,
I can watch tv with sound but my remote control doesnt work. There is no ir
event in /proc/bus/input/device .
When bttv module is loaded with "card=137" option remote control works very
well.

$ cat /proc/bus/input/devices
.......
........
: Bus=0001 Vendor=109e Product=0350 Version=0001
N: Name="bttv IR (card=137)"
P: Phys=pci-0000:00:0d.0/ir0
S: Sysfs=/devices/pci0000:00/0000:00:0d.0/input/input144
U: Uniq=
H: Handlers=kbd event6
B: EV=100003
B: KEY=2c0814 100004 0 0 0 4 2008000 2090 2001 1e0000 4400 0 ffc

Unfortunately there is no sound.
"""

https://bugs.launchpad.net/ubuntu/+bug/239733
http://bugzilla.kernel.org/show_bug.cgi?id=11995

-- 
Regards, Pablo.

[-- Attachment #2: kernel_add_remote_support_for_cph03x.diff --]
[-- Type: text/plain, Size: 1180 bytes --]

diff -Nurp linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-cards.c linux-source-2.6.27/drivers/media/video/bt8xx/bttv-cards.c
--- linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-cards.c	2008-11-09 18:05:17.000000000 +0100
+++ linux-source-2.6.27/drivers/media/video/bt8xx/bttv-cards.c	2008-11-09 18:05:46.000000000 +0100
@@ -1362,6 +1362,7 @@ struct tvcard bttv_tvcards[] = {
 		.tuner_type	= TUNER_TEMIC_PAL,
 		.tuner_addr	= ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
+		.has_remote	= 1,
 	},
 
 	/* ---- card 0x3c ---------------------------------- */
diff -Nurp linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-input.c linux-source-2.6.27/drivers/media/video/bt8xx/bttv-input.c
--- linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-input.c	2008-11-09 18:05:17.000000000 +0100
+++ linux-source-2.6.27/drivers/media/video/bt8xx/bttv-input.c	2008-11-09 18:05:39.000000000 +0100
@@ -260,6 +260,7 @@ int bttv_input_init(struct bttv *btv)
 		ir->mask_keyup   = 0x008000;
 		ir->polling      = 50; // ms
 		break;
+	case BTTV_BOARD_ASKEY_CPH03X:
 	case BTTV_BOARD_CONCEPTRONIC_CTVFMI2:
 	case BTTV_BOARD_CONTVFMI:
 		ir_codes         = ir_codes_pixelview;

                 reply	other threads:[~2009-08-22 17:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A902E56.9000604@gmail.com \
    --to=pablog.ubuntu@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox