* [PATCH 2/2] v4l2: remove unnecessary vidioc_s_std() from gspca
@ 2009-07-07 6:18 Németh Márton
2009-08-23 9:30 ` [RESEND][PATCH " Németh Márton
0 siblings, 1 reply; 2+ messages in thread
From: Németh Márton @ 2009-07-07 6:18 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Jean-Francois Moine, linux-media; +Cc: LKML
From: Márton Németh <nm127@freemail.hu>
The vidioc_s_std() is not necessary when vdev->tvnorms == 0. [1]
The changeset was tested together with v4l-test 0.16 [2] with
gspca_sunplus driver together with Trust 610 LCD POWERC@M ZOOM.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/x448.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--- linux-2.6.31-rc1/drivers/media/video/gspca/gspca.c.orig 2009-06-25 01:25:37.000000000 +0200
+++ linux-2.6.31-rc1/drivers/media/video/gspca/gspca.c 2009-07-06 08:14:19.000000000 +0200
@@ -1405,12 +1405,6 @@ static int vidioc_s_parm(struct file *fi
return 0;
}
-static int vidioc_s_std(struct file *filp, void *priv,
- v4l2_std_id *parm)
-{
- return 0;
-}
-
#ifdef CONFIG_VIDEO_V4L1_COMPAT
static int vidiocgmbuf(struct file *file, void *priv,
struct video_mbuf *mbuf)
@@ -1881,7 +1875,6 @@ static const struct v4l2_ioctl_ops dev_i
.vidioc_s_jpegcomp = vidioc_s_jpegcomp,
.vidioc_g_parm = vidioc_g_parm,
.vidioc_s_parm = vidioc_s_parm,
- .vidioc_s_std = vidioc_s_std,
.vidioc_enum_framesizes = vidioc_enum_framesizes,
#ifdef CONFIG_VIDEO_V4L1_COMPAT
.vidiocgmbuf = vidiocgmbuf,
^ permalink raw reply [flat|nested] 2+ messages in thread* [RESEND][PATCH 2/2] v4l2: remove unnecessary vidioc_s_std() from gspca
2009-07-07 6:18 [PATCH 2/2] v4l2: remove unnecessary vidioc_s_std() from gspca Németh Márton
@ 2009-08-23 9:30 ` Németh Márton
0 siblings, 0 replies; 2+ messages in thread
From: Németh Márton @ 2009-08-23 9:30 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Jean-Francois Moine, Thomas Kaiser,
linux-media; +Cc: LKML
From: Márton Németh <nm127@freemail.hu>
The vidioc_s_std() is not necessary when vdev->tvnorms == 0. [1]
The changeset was tested together with v4l-test 0.19 [2] with
gspca_sunplus driver together with Trust 610 LCD POWERC@M ZOOM and
with gspca_pac7311 together with Labtec Webcam 2200.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/x448.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--- linux-2.6.31-rc7.orig/drivers/media/video/gspca/gspca.c 2009-08-23 07:36:08.000000000 +0200
+++ linux-2.6.31-rc7/drivers/media/video/gspca/gspca.c 2009-08-23 11:06:22.000000000 +0200
@@ -1473,12 +1473,6 @@ static int vidioc_s_parm(struct file *fi
return 0;
}
-static int vidioc_s_std(struct file *filp, void *priv,
- v4l2_std_id *parm)
-{
- return 0;
-}
-
#ifdef CONFIG_VIDEO_V4L1_COMPAT
static int vidiocgmbuf(struct file *file, void *priv,
struct video_mbuf *mbuf)
@@ -1949,7 +1943,6 @@ static const struct v4l2_ioctl_ops dev_i
.vidioc_s_jpegcomp = vidioc_s_jpegcomp,
.vidioc_g_parm = vidioc_g_parm,
.vidioc_s_parm = vidioc_s_parm,
- .vidioc_s_std = vidioc_s_std,
.vidioc_enum_framesizes = vidioc_enum_framesizes,
#ifdef CONFIG_VIDEO_ADV_DEBUG
.vidioc_g_register = vidioc_g_register,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-23 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-07 6:18 [PATCH 2/2] v4l2: remove unnecessary vidioc_s_std() from gspca Németh Márton
2009-08-23 9:30 ` [RESEND][PATCH " Németh Márton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox