From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from static-72-93-233-3.bstnma.fios.verizon.net ([72.93.233.3]:52493 "EHLO mail.wilsonet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbZIBDWx (ORCPT ); Tue, 1 Sep 2009 23:22:53 -0400 Message-ID: <4A9DE5FE.8060409@wilsonet.com> Date: Tue, 01 Sep 2009 23:26:54 -0400 From: Jarod Wilson MIME-Version: 1.0 To: Andy Walls CC: Jarod Wilson , Janne Grunau , linux-media@vger.kernel.org, Brandon Jenkins Subject: Re: [PATCH] hdpvr: i2c fixups for fully functional IR support References: <200909011019.35798.jarod@redhat.com> <1251855051.3926.34.camel@palomino.walls.org> In-Reply-To: <1251855051.3926.34.camel@palomino.walls.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/01/2009 09:30 PM, Andy Walls wrote: > On Tue, 2009-09-01 at 10:19 -0400, Jarod Wilson wrote: >> Patch is against http://hg.jannau.net/hdpvr/ >> >> 1) Adds support for building hdpvr i2c support when i2c is built as a >> module (based on work by David Engel on the mythtv-users list) >> >> 2) Refines the hdpvr_i2c_write() success check (based on a thread in >> the sagetv forums) >> >> With this patch in place, and the latest lirc_zilog driver in my lirc >> git tree, the IR part in my hdpvr works perfectly, both for reception >> and transmitting. >> >> Signed-off-by: Jarod Wilson > > Jarod, > > I recall a problem Brandon Jenkins had from last year, that when I2C was > enabled in hdpvr, his machine with multiple HVR-1600s and an HD-PVR > would produce a kernel oops. > > Have you tested this on a machine with both an HVR-1600 and HD-PVR > installed? Hrm, no, haven't tested it with such a setup, don't have an HVR-1600. I do have an HVR-1250 that I think might suffice for testing though, if I'm thinking clearly. Ugh. And I just noticed that while everything works swimmingly with a 2.6.30 kernel base, the i2c changes in 2.6.31 actually break it, so there's gonna be at least one more patch coming... I'm an idjit for not testing w/2.6.31 before sending this in, I *knew* there were major i2c changes to account for... (Its actually the hdpvr driver oopsing, before one even tries loading lirc_zilog). -- Jarod Wilson jarod@wilsonet.com