Re: [PATCH] hdpvr: i2c fixups for fully functional IR support

[Jarod Wilson <jarod@wilsonet.com>]

On 09/03/2009 05:32 PM, Janne Grunau wrote:
> On Thu, Sep 03, 2009 at 04:02:12PM -0400, Jarod Wilson wrote:
>> On Sep 3, 2009, at 7:50 AM, Andy Walls wrote:
>>
>>>> Hrm. A brief google search suggests the 1250 IR part isn't enabled. I
>>>> see a number of i2c devices in i2cdetect -l output, but none that say
>>>> anything about IR... I could just plug the hdpvr in there and see
>>>> what
>>>> happens, I suppose...
>>>
>>> You should try that.  It was an issue of legacy I2C driver probing
>>> that
>>> caused the hdpvr module to have problems.  The cx18 driver simply
>>> stimulated the i2c subsystem to do legacy probing (via the tuner
>>> modules
>>> IIRC)?  See the email I sent you.
>>
>> So from what I can tell, the i2c changes in 2.6.31 *should* prevent
>> that from happening, and now that I've got everything working on
>> 2.6.31 too, I'll try hooking up my hdpvr to my box w/an hvr-1250,
>> hvr-1800 and pchdtv hd-3000 in it and see what blows up (hopefully
>> nothing...).
>
> We still need something to prevent it from happening with older kernels.
> Easiest solution would be to disable it for 2.6.30 and earlier.

So I just tried a few permutations of hooking it up to the previously 
mentioned box, running a 2.6.29.6 kernel. No oops hooking the hdpvr up 
after everything else is already up, and no problems booting the system 
w/the hdpvr already connected (in which case it was the first device set 
up). One i2c adapter exposed by the hd-3000, three each by the hvr-1800 
and the hvr-1250, and the one on the hdpvr.

So perhaps we're okay, but I couldn't say for certain if its okay in 
combination with the hvr-1600 (i.e. Brandon's setup). Maybe skip 
enabling the i2c bits by default on kernels prior to 2.6.31, but add a 
modparam to let people enable them if they want to try it out?

-- 
Jarod Wilson
jarod@wilsonet.com