(Saa7134) Re: ADS-Tech Instant TV PCI, no remote support

[Morvan Le Meut <mlemeut@gmail.com>]

Morvan Le Meut a écrit :
> Hello all
> This is an old card i bough by error ( wanted the DVB-T version ) but 
> i tried it and i see a small problem :
> The remote isn't supported. ( If it is, i wonder why my computer don't 
> see it )
>
> I found an old patch to add remote support to it here :
>
> http://tfpsly.free.fr/Files/Instant_TV_PCI_remote/saa7134_patch_for_AdsInstantTVPCI.gz 
>
> ( The webpage talking about it is 
> http://tfpsly.free.fr/francais/index.html?url=http://tfpsly.free.fr/Files/Instant_TV_PCI_remote/index.html 
> in french )
>
> But since i found out long ago that i shouldn't even think of altering 
> a source file, could someone adapt that old patch to correct this ? ( 
> should be quick, i guess )
>
> Thanks.
>
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Well, i'm trying it myself ( by hand, since the patch looks old ) :
adding
case SAA7134_BOARD_ADS_INSTANT_TV: at line 6659 in saa7134-cards.c
(before "dev->has_remote = SAA7134_REMOTE_GPIO;" )
is that correct ?
but from the diff file i should add what seems to be the remote keycode 
in saa7134-input.c
"+static IR_KEYTAB_TYPE AdsInstantTvPci_codes[IR_KEYTAB_SIZE] = {
+    // Buttons are in the top to bottom physical order
+    // Some buttons return the same raw code, so they are currently 
disabled
+    [ 127] = KEY_FINANCE,   // "release all keys" code - prevent 
repeating enlessly a key
+   
+    [ 27 ] = KEY_POWER,"
( and so on )
 Since i didn't see other keycodes for the other cards, i guess this is 
wrong, so where should i add them ?
( i barely understand what i am doing right now :p )

Thanks