public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Andreas Mohr <andi@lisas.de>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Luca Risolia <luca.risolia@studio.unibo.it>,
	linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	jirislaby@gmail.com
Subject: Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation
Date: Tue, 15 Sep 2009 21:14:19 +0200	[thread overview]
Message-ID: <4AAFE78B.6060606@gmail.com> (raw)
In-Reply-To: <20090914210741.GA16799@rhlx01.hs-esslingen.de>

Andreas Mohr pisze:
> Hi all,
> 
> ./drivers/media/video/sn9c102/sn9c102_core.c
> ,
> ./drivers/media/video/et61x251/et61x251_core.c
> and
> ./drivers/media/video/zc0301/zc0301_core.c
> do
>                             cam->module_param.frame_timeout *
>                             1000 * msecs_to_jiffies(1) );
> multiple times each.
> What they should do instead is
> frame_timeout * msecs_to_jiffies(1000), I'd think.

Or better: frame_timeout * HZ

Marcin

  parent reply	other threads:[~2009-09-15 19:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 21:07 V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation Andreas Mohr
2009-09-14 21:34 ` Jiri Slaby
2009-09-14 21:39   ` Andreas Mohr
2009-09-14 21:50     ` Jiri Slaby
2009-09-14 22:13       ` Andreas Mohr
2009-09-14 21:47 ` Trent Piepho
2009-09-15 19:14 ` Marcin Slusarz [this message]
2009-09-15 19:21   ` Andreas Mohr
2009-09-19 10:08     ` Andreas Mohr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAFE78B.6060606@gmail.com \
    --to=marcin.slusarz@gmail.com \
    --cc=andi@lisas.de \
    --cc=g.liakhovetski@gmx.de \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=luca.risolia@studio.unibo.it \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox