* [PATCH] V4L/DVB (7969): kmalloc failure ignored in m920x_firmware_download()
@ 2009-09-18 23:10 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-09-18 23:10 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media, Andrew Morton
Prevent NULL dereference if kmalloc() fails.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Found with sed: http://kernelnewbies.org/roelkluin
Build tested.
diff --git a/drivers/media/dvb/dvb-usb/m920x.c b/drivers/media/dvb/dvb-usb/m920x.c
index aec7a19..ef9b7be 100644
--- a/drivers/media/dvb/dvb-usb/m920x.c
+++ b/drivers/media/dvb/dvb-usb/m920x.c
@@ -337,6 +337,8 @@ static int m920x_firmware_download(struct usb_device *udev, const struct firmwar
int i, pass, ret = 0;
buff = kmalloc(65536, GFP_KERNEL);
+ if (buff == NULL)
+ return -ENOMEM;
if ((ret = m920x_read(udev, M9206_FILTER, 0x0, 0x8000, read, 4)) != 0)
goto done;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-18 23:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-18 23:10 [PATCH] V4L/DVB (7969): kmalloc failure ignored in m920x_firmware_download() Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox