* [PATCH] saa7146 memory leakage in pagetable-handling
@ 2009-09-28 10:49 Johann Friedrichs
0 siblings, 0 replies; only message in thread
From: Johann Friedrichs @ 2009-09-28 10:49 UTC (permalink / raw)
To: linux-media
It is necessary to release the allocated pgtables in buffer_release. It
is now done only in buffer_prepare. This will not work if a new
videobuf_buffer has been requested since the last call, as the former
pointers are lost.
Signed-off-by: johann.friedrichs@web.de
--- a/drivers/media/common/saa7146_video.c 2009-04-17
21:42:35.000000000 +0200
+++ b/drivers/media/common/saa7146_video.c 2009-09-22
09:03:50.000000000 +0200
@@ -1331,6 +1331,9 @@ static void buffer_release(struct videob
DEB_CAP(("vbuf:%p\n",vb));
saa7146_dma_free(dev,q,buf);
+ saa7146_pgtable_free(dev->pci, &buf->pt[0]);
+ saa7146_pgtable_free(dev->pci, &buf->pt[1]);
+ saa7146_pgtable_free(dev->pci, &buf->pt[2]);
}
static struct videobuf_queue_ops video_qops = {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-28 10:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-28 10:49 [PATCH] saa7146 memory leakage in pagetable-handling Johann Friedrichs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).