public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Filipe Rosset <rosset.filipe@gmail.com>
To: linux-media@vger.kernel.org
Cc: Douglas Schilling Landgraf <dougsland@gmail.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 2/2] em28xx: Convert printks to em28xx_err and em28xx_info
Date: Mon, 28 Sep 2009 12:03:57 -0300	[thread overview]
Message-ID: <4AC0D05D.4060304@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: Convert_printks_to_em28xx_err_and_em28xx_info.diff --]
[-- Type: text/plain, Size: 2076 bytes --]

em28xx: Convert printks to em28xx_err and em28xx_info

From: Filipe Rosset <rosset.filipe@gmail.com>

Convert printks to em28xx_err and em28xx_info

Priority: normal

Signed-off-by: Filipe Rosset <rosset.filipe@gmail.com>

diff -r cbf8899e0fd4 linux/drivers/media/video/em28xx/em28xx-dvb.c
--- a/linux/drivers/media/video/em28xx/em28xx-dvb.c	Mon Sep 28 11:22:23 2009 -0300
+++ b/linux/drivers/media/video/em28xx/em28xx-dvb.c	Mon Sep 28 11:52:23 2009 -0300
@@ -314,7 +314,7 @@
 	cfg.i2c_addr  = addr;
 
 	if (!dev->dvb->frontend) {
-		printk(KERN_ERR "%s/2: dvb frontend not attached. "
+		em28xx_err("%s/2: dvb frontend not attached. "
 				"Can't attach xc3028\n",
 		       dev->name);
 		return -EINVAL;
@@ -322,14 +322,14 @@
 
 	fe = dvb_attach(xc2028_attach, dev->dvb->frontend, &cfg);
 	if (!fe) {
-		printk(KERN_ERR "%s/2: xc3028 attach failed\n",
+		em28xx_err("%s/2: xc3028 attach failed\n",
 		       dev->name);
 		dvb_frontend_detach(dev->dvb->frontend);
 		dev->dvb->frontend = NULL;
 		return -EINVAL;
 	}
 
-	printk(KERN_INFO "%s/2: xc3028 attached\n", dev->name);
+	em28xx_info("%s/2: xc3028 attached\n", dev->name);
 
 	return 0;
 }
@@ -464,7 +464,7 @@
 	dvb = kzalloc(sizeof(struct em28xx_dvb), GFP_KERNEL);
 
 	if (dvb == NULL) {
-		printk(KERN_INFO "em28xx_dvb: memory allocation failed\n");
+		em28xx_info("em28xx_dvb: memory allocation failed\n");
 		return -ENOMEM;
 	}
 	dev->dvb = dvb;
@@ -570,14 +570,13 @@
 		}
 		break;
 	default:
-		printk(KERN_ERR "%s/2: The frontend of your DVB/ATSC card"
+		em28xx_err("%s/2: The frontend of your DVB/ATSC card"
 				" isn't supported yet\n",
 		       dev->name);
 		break;
 	}
 	if (NULL == dvb->frontend) {
-		printk(KERN_ERR
-		       "%s/2: frontend initialization failed\n",
+		em28xx_err("%s/2: frontend initialization failed\n",
 		       dev->name);
 		result = -EINVAL;
 		goto out_free;
@@ -592,7 +591,7 @@
 		goto out_free;
 
 	em28xx_set_mode(dev, EM28XX_SUSPEND);
-	printk(KERN_INFO "Successfully loaded em28xx-dvb\n");
+	em28xx_info("Successfully loaded em28xx-dvb\n");
 	return 0;
 
 out_free:

             reply	other threads:[~2009-09-28 15:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28 15:03 Filipe Rosset [this message]
2009-09-28 15:24 ` [PATCH 2/2] em28xx: Convert printks to em28xx_err and em28xx_info Devin Heitmueller
2009-09-28 16:19   ` Filipe Rosset
2009-09-28 16:23     ` Devin Heitmueller
2009-09-28 16:43       ` Filipe Rosset
2009-09-28 18:05         ` Devin Heitmueller
2009-09-28 18:17           ` Filipe Rosset

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC0D05D.4060304@gmail.com \
    --to=rosset.filipe@gmail.com \
    --cc=dougsland@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox