* [PATCH] dvb-usb-friio: accept center-shifted frequency
@ 2009-11-12 7:02 Akihiro TSUKADA
2009-11-19 15:21 ` Patrick Boettcher
0 siblings, 1 reply; 2+ messages in thread
From: Akihiro TSUKADA @ 2009-11-12 7:02 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Mauro Carvalho Chehab
From: Akihiro Tsukada <tskd2@yahoo.co.jp>
This patch adds a fix to accept frequency with its center shifted.
The driver used to accept center frequencies of the normal UHF band channels,
but in ISDB-T, center frequency is shifted with 1/7MHz.
It was shifted internally in the driver,
but this patch enables to accept both types of frequency.
Priority: normal
Signed-off-by: Akihiro Tsukada <tskd2@yahoo.co.jp>
---
friio-fe.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/linux/drivers/media/dvb/dvb-usb/friio-fe.c b/linux/drivers/media/dvb/dvb-usb/friio-fe.c
--- a/linux/drivers/media/dvb/dvb-usb/friio-fe.c
+++ b/linux/drivers/media/dvb/dvb-usb/friio-fe.c
@@ -134,11 +134,13 @@ static int jdvbt90502_pll_set_freq(struc
deb_fe("%s: freq=%d, step=%d\n", __func__, freq,
state->frontend.ops.info.frequency_stepsize);
/* freq -> oscilator frequency conversion. */
- /* freq: 473,000,000 + n*6,000,000 (no 1/7MHz shift to center freq) */
- /* add 400[1/7 MHZ] = 57.142857MHz. 57MHz for the IF, */
- /* 1/7MHz for center freq shift */
+ /* freq: 473,000,000 + n*6,000,000 [+ 142857 (center freq. shift)] */
f = freq / state->frontend.ops.info.frequency_stepsize;
- f += 400;
+ /* add 399[1/7 MHZ] = 57MHz for the IF */
+ f += 399;
+ /* add center frequency shift if necessary */
+ if (f % 7 == 0)
+ f++;
pll_freq_cmd[DEMOD_REDIRECT_REG] = JDVBT90502_2ND_I2C_REG; /* 0xFE */
pll_freq_cmd[ADDRESS_BYTE] = state->config.pll_address << 1;
pll_freq_cmd[DIVIDER_BYTE1] = (f >> 8) & 0x7F;
--------------------------------------
GyaO! - Anime, Dramas, Movies, and Music videos [FREE]
http://pr.mail.yahoo.co.jp/gyao/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dvb-usb-friio: accept center-shifted frequency
2009-11-12 7:02 [PATCH] dvb-usb-friio: accept center-shifted frequency Akihiro TSUKADA
@ 2009-11-19 15:21 ` Patrick Boettcher
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Boettcher @ 2009-11-19 15:21 UTC (permalink / raw)
To: Akihiro TSUKADA; +Cc: Linux Media Mailing List, Mauro Carvalho Chehab
Hi Akihiro,
On Thu, 12 Nov 2009, Akihiro TSUKADA wrote:
> From: Akihiro Tsukada <tskd2@yahoo.co.jp>
>
> This patch adds a fix to accept frequency with its center shifted.
>
> The driver used to accept center frequencies of the normal UHF band channels,
> but in ISDB-T, center frequency is shifted with 1/7MHz.
> It was shifted internally in the driver,
> but this patch enables to accept both types of frequency.
>
> Priority: normal
>
> Signed-off-by: Akihiro Tsukada <tskd2@yahoo.co.jp>
> ---
> friio-fe.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/linux/drivers/media/dvb/dvb-usb/friio-fe.c b/linux/drivers/media/dvb/dvb-usb/friio-fe.c
> --- a/linux/drivers/media/dvb/dvb-usb/friio-fe.c
> +++ b/linux/drivers/media/dvb/dvb-usb/friio-fe.c
> @@ -134,11 +134,13 @@ static int jdvbt90502_pll_set_freq(struc
> deb_fe("%s: freq=%d, step=%d\n", __func__, freq,
> state->frontend.ops.info.frequency_stepsize);
> /* freq -> oscilator frequency conversion. */
> - /* freq: 473,000,000 + n*6,000,000 (no 1/7MHz shift to center freq) */
> - /* add 400[1/7 MHZ] = 57.142857MHz. 57MHz for the IF, */
> - /* 1/7MHz for center freq shift */
> + /* freq: 473,000,000 + n*6,000,000 [+ 142857 (center freq. shift)] */
> f = freq / state->frontend.ops.info.frequency_stepsize;
> - f += 400;
> + /* add 399[1/7 MHZ] = 57MHz for the IF */
> + f += 399;
> + /* add center frequency shift if necessary */
> + if (f % 7 == 0)
> + f++;
> pll_freq_cmd[DEMOD_REDIRECT_REG] = JDVBT90502_2ND_I2C_REG; /* 0xFE */
> pll_freq_cmd[ADDRESS_BYTE] = state->config.pll_address << 1;
> pll_freq_cmd[DIVIDER_BYTE1] = (f >> 8) & 0x7F;
I applied your patch, I will later asked Mauro to pull it into main.
thanks,
--
Patrick
http://www.kernellabs.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-19 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-12 7:02 [PATCH] dvb-usb-friio: accept center-shifted frequency Akihiro TSUKADA
2009-11-19 15:21 ` Patrick Boettcher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox