Re: [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR )

["Andrea.Amorosi76@gmail.com" <Andrea.Amorosi76@gmail.com>]

Andrea.Amorosi76@gmail.com wrote:
> This patch fix the Dikom DK300 hybrid usb card which is recognized as a
> Kworld VS-DVB-T 323UR (card=54).
>
> The patch adds digital tv and solves analog tv audio bad quality issue.
>
> Signed-off-by: Andrea Amorosi <Andrea.Amorosi76@gmail.com>
>
> diff -r aba823ecaea6 linux/drivers/media/video/em28xx/em28xx-cards.c
> --- a/linux/drivers/media/video/em28xx/em28xx-cards.c    Thu Nov 12 
> 12:21:05 2009 -0200
> +++ b/linux/drivers/media/video/em28xx/em28xx-cards.c    Sat Nov 14 
> 23:10:47 2009 +0100
> @@ -1422,18 +1422,24 @@
>         .tuner_type   = TUNER_XC2028,
>         .tuner_gpio   = default_tuner_gpio,
>         .decoder      = EM28XX_TVP5150,
> +                .mts_firmware = 1,
> +                .has_dvb      = 1,
> +                .dvb_gpio     = 
> kworld_330u_digital,                                                                                                                                                         
>
>         .input        = { {
>             .type     = EM28XX_VMUX_TELEVISION,
>             .vmux     = TVP5150_COMPOSITE0,
>             .amux     = EM28XX_AMUX_VIDEO,
> +            .gpio     = default_analog,
>         }, {
>             .type     = EM28XX_VMUX_COMPOSITE1,
>             .vmux     = TVP5150_COMPOSITE1,
>             .amux     = EM28XX_AMUX_LINE_IN,
> +            .gpio     = default_analog,
>         }, {
>             .type     = EM28XX_VMUX_SVIDEO,
>             .vmux     = TVP5150_SVIDEO,
>             .amux     = EM28XX_AMUX_LINE_IN,
> +            .gpio     = default_analog,
>         } },
>     },
>     [EM2882_BOARD_TERRATEC_HYBRID_XS] = {
> @@ -2143,6 +2149,7 @@
>         ctl->demod = XC3028_FE_DEFAULT;
>         break;
>     case EM2883_BOARD_KWORLD_HYBRID_330U:
> +    case EM2882_BOARD_KWORLD_VS_DVBT:
>         ctl->demod = XC3028_FE_CHINA;
>         ctl->fname = XC2028_DEFAULT_FIRMWARE;
>         break;
> diff -r aba823ecaea6 linux/drivers/media/video/em28xx/em28xx-dvb.c
> --- a/linux/drivers/media/video/em28xx/em28xx-dvb.c    Thu Nov 12 
> 12:21:05 2009 -0200
> +++ b/linux/drivers/media/video/em28xx/em28xx-dvb.c    Sat Nov 14 
> 23:10:47 2009 +0100
> @@ -504,6 +504,7 @@
>         break;
>     case EM2880_BOARD_TERRATEC_HYBRID_XS:
>     case EM2881_BOARD_PINNACLE_HYBRID_PRO:
> +    case EM2882_BOARD_KWORLD_VS_DVBT:
>         dvb->frontend = dvb_attach(zl10353_attach,
>                        &em28xx_zl10353_xc3028_no_i2c_gate,
>                        &dev->i2c_adap);
>
>
Should I remove the    "     .valid        = 
EM28XX_BOARD_NOT_VALIDATED," line from the device, since I have 
successfully tested it or the maintainer will remove it after having 
received positive feedbacks from other users/developers?

For the sake of completeness, the device has a strange behaviour of its 
two blue LEDs (whose light is visible because  the upper part of the 
device is semi transparent):
when the device is connected they turn on and then turn off after less 
than a second;
if I see analogue TV with Mplayer, one of them turn on and remain in 
such a state till Mplayer is closed.
if I see digital TV with Kaffeine, the other led remains off till I 
select digital TV and a channel, but then it turns on and remain active 
even if I close Kaffeine and open Mplayer to see analogue tv. In such a 
case both the LEDs are turned on and the analogue one continue to behave 
correctly because if I close mplayer it turns off. The digital led turns 
off only if I reopen Kaffeine without selecting the digital TV.
May this strange behaviour be the symptom of an incorrect switch off of 
the digital part of the tuner when it is not used any more by some programs?
Even my previous device (Empire dual pen) had such a strange behaviour 
as far as the light is concerned, so I don't think it is a real problem.
However if someone knows how to solve this, it is better.

Best regards,
Andrea