public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: e9hack <e9hack@googlemail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: bug in changeset 13239:54535665f94b ?
Date: Thu, 19 Nov 2009 22:02:41 +0100	[thread overview]
Message-ID: <4B05B271.5070707@googlemail.com> (raw)
In-Reply-To: <20091107104113.0df4593b@pedra.chehab.org>

Mauro Carvalho Chehab schrieb:
> Could you please test if the enclosed patch fixes the issue?
> 
> saa7146: stop DMA before de-allocating DMA scatter/gather page buffers
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> 
> diff --git a/linux/drivers/media/common/saa7146_video.c b/linux/drivers/media/common/saa7146_video.c
> --- a/linux/drivers/media/common/saa7146_video.c
> +++ b/linux/drivers/media/common/saa7146_video.c
> @@ -1334,9 +1334,9 @@ static void buffer_release(struct videob
>  
>  	DEB_CAP(("vbuf:%p\n",vb));
>  
> +	saa7146_dma_free(dev,q,buf);
> +
>  	release_all_pagetables(dev, buf);
> -
> -	saa7146_dma_free(dev,q,buf);
>  }
>  
>  static struct videobuf_queue_ops video_qops = {

Hi Mauro,

can you please commit this patch? It's perfect just I wrote here
(http://news.gmane.org/gmane.linux.drivers.video-input-infrastructure).

Regards,
Hartmut



  parent reply	other threads:[~2009-11-19 21:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 15:59 bug in changeset 13239:54535665f94b ? e9hack
2009-11-02 20:27 ` e9hack
2009-11-07 12:41 ` Mauro Carvalho Chehab
2009-11-07 14:05   ` e9hack
2009-11-07 14:49     ` Mauro Carvalho Chehab
2009-11-07 16:00       ` e9hack
2009-11-07 18:35     ` e9hack
2009-11-08 20:48   ` Johann Friedrichs
2009-11-19 21:02   ` e9hack [this message]
2009-11-19 21:15     ` e9hack
2009-11-23 19:29       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B05B271.5070707@googlemail.com \
    --to=e9hack@googlemail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox