From: Michael Krufky <mkrufky@linuxtv.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] V4L/DVB: Fix test in copy_reg_bits()
Date: Fri, 20 Nov 2009 19:53:09 -0500 [thread overview]
Message-ID: <4B0739F5.4090403@linuxtv.org> (raw)
In-Reply-To: <4B06E125.6090305@gmail.com>
Ah! Nice catch. Thank you, Roel. Mauro / Andrew, can one of you
please merge this? The driver hasn't changed, so it should go to Linus'
current tree and also stable, although it isn't crucial.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Roel Kluin wrote:
> The reg_pair2[j].reg was tested twice.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/media/common/tuners/mxl5007t.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I think this was intended?
>
> diff --git a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> index 2d02698..7eb1bf7 100644
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1,
> i = j = 0;
>
> while (reg_pair1[i].reg || reg_pair1[i].val) {
> - while (reg_pair2[j].reg || reg_pair2[j].reg) {
> + while (reg_pair2[j].reg || reg_pair2[j].val) {
> if (reg_pair1[i].reg != reg_pair2[j].reg) {
> j++;
> continue;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-11-21 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 18:34 [PATCH] V4L/DVB: Fix test in copy_reg_bits() Roel Kluin
2009-11-21 0:53 ` Michael Krufky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0739F5.4090403@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox