* [PATCH] V4L/DVB: Fix test in copy_reg_bits()
@ 2009-11-20 18:34 Roel Kluin
2009-11-21 0:53 ` Michael Krufky
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-11-20 18:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media, Andrew Morton, LKML, mkrufky
The reg_pair2[j].reg was tested twice.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/media/common/tuners/mxl5007t.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I think this was intended?
diff --git a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
index 2d02698..7eb1bf7 100644
--- a/drivers/media/common/tuners/mxl5007t.c
+++ b/drivers/media/common/tuners/mxl5007t.c
@@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1,
i = j = 0;
while (reg_pair1[i].reg || reg_pair1[i].val) {
- while (reg_pair2[j].reg || reg_pair2[j].reg) {
+ while (reg_pair2[j].reg || reg_pair2[j].val) {
if (reg_pair1[i].reg != reg_pair2[j].reg) {
j++;
continue;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] V4L/DVB: Fix test in copy_reg_bits()
2009-11-20 18:34 [PATCH] V4L/DVB: Fix test in copy_reg_bits() Roel Kluin
@ 2009-11-21 0:53 ` Michael Krufky
0 siblings, 0 replies; 2+ messages in thread
From: Michael Krufky @ 2009-11-21 0:53 UTC (permalink / raw)
To: Roel Kluin; +Cc: Mauro Carvalho Chehab, linux-media, Andrew Morton, LKML
Ah! Nice catch. Thank you, Roel. Mauro / Andrew, can one of you
please merge this? The driver hasn't changed, so it should go to Linus'
current tree and also stable, although it isn't crucial.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Roel Kluin wrote:
> The reg_pair2[j].reg was tested twice.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/media/common/tuners/mxl5007t.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I think this was intended?
>
> diff --git a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> index 2d02698..7eb1bf7 100644
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1,
> i = j = 0;
>
> while (reg_pair1[i].reg || reg_pair1[i].val) {
> - while (reg_pair2[j].reg || reg_pair2[j].reg) {
> + while (reg_pair2[j].reg || reg_pair2[j].val) {
> if (reg_pair1[i].reg != reg_pair2[j].reg) {
> j++;
> continue;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-21 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-20 18:34 [PATCH] V4L/DVB: Fix test in copy_reg_bits() Roel Kluin
2009-11-21 0:53 ` Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox