public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <maurochehab@gmail.com>
To: "Lukáš Karas" <lukas.karas@centrum.cz>
Cc: linux-media@vger.kernel.org, Petr Fiala <petr.fiala@gmail.com>,
	hermann pitton <hermann-pitton@arcor.de>
Subject: Re: [PATCH] Multifrontend support for saa7134
Date: Mon, 23 Nov 2009 14:04:17 -0200	[thread overview]
Message-ID: <4B0AB281.4080802@gmail.com> (raw)
In-Reply-To: <200910312121.21926.lukas.karas@centrum.cz>

Hi Lukáš/Hermann,

Any news about this patch? I'll mark it as RFC at the patchwork, since it seems that this is not finished yet. Please let me know if you make some progress.

> @@ -1352,6 +1353,7 @@ struct saa7134_board saa7134_boards[] =
>  		.tuner_addr     = ADDR_UNSET,
>  		.radio_addr     = ADDR_UNSET,
>  		 .mpeg           = SAA7134_MPEG_DVB,
> +		 .num_frontends  = 1,
>  		 .inputs         = {{
>  			 .name = name_tv,
>  			 .vmux = 1,

Just one suggestion here: it is a way better to assume that an "uninitialized" value (e. g. num_frontends = 0) for num_frontends to mean that just one frontend exists. This saves space at the initialization segment
of the module and avoids the risk of someone forget to add num_frontends=0.

cheers,
Mauro.

  parent reply	other threads:[~2009-11-23 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-31 20:21 [PATCH] Multifrontend support for saa7134 Lukáš Karas
2009-11-01  2:40 ` hermann pitton
2009-11-03  1:02   ` hermann pitton
2009-11-05 18:39   ` Lukáš Karas
2009-11-06  2:16     ` hermann pitton
2009-11-17 14:06       ` Lukáš Karas
2009-11-18  3:40         ` hermann pitton
2009-11-23 16:04 ` Mauro Carvalho Chehab [this message]
2009-11-24  1:08   ` hermann pitton
2009-12-02  2:21     ` hermann pitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0AB281.4080802@gmail.com \
    --to=maurochehab@gmail.com \
    --cc=hermann-pitton@arcor.de \
    --cc=linux-media@vger.kernel.org \
    --cc=lukas.karas@centrum.cz \
    --cc=petr.fiala@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox