public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "David T. L. Wong" <davidtlwong@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: v4l-dvb <linux-media@vger.kernel.org>
Subject: [PATCH] cxusb: Mygica D689 compilation warning fix and clean up
Date: Sat, 28 Nov 2009 19:36:26 +0800	[thread overview]
Message-ID: <4B110B3A.3030401@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi,

   This patch fix compilation warning for cxusb mygica d689 and clean up 
unused code.

Regards,
David

Signed-off-by: David T. L. Wong <davidtlwong@gmail.com>


[-- Attachment #2: mygica_d689_fix_warnings.patch --]
[-- Type: text/x-patch, Size: 841 bytes --]

diff --git a/linux/drivers/media/dvb/dvb-usb/cxusb.c b/linux/drivers/media/dvb/dvb-usb/cxusb.c
--- a/linux/drivers/media/dvb/dvb-usb/cxusb.c
+++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c
@@ -1195,7 +1195,6 @@
 static int cxusb_mygica_d689_frontend_attach(struct dvb_usb_adapter *adap)
 {
 	struct dvb_usb_device *d = adap->dev;
-	int n;
 
 	/* Select required USB configuration */
 	if (usb_set_interface(d->udev, 0, 0) < 0)
@@ -1209,15 +1208,6 @@
 	usb_clear_halt(d->udev,
 		usb_rcvbulkpipe(d->udev, d->props.adapter[0].stream.endpoint));
 
-#if 0
-	/* Drain USB pipes to avoid hang after reboot */
-	for (n = 0;  n < 5;  n++) {
-		cxusb_d680_dmb_drain_message(d);
-		cxusb_d680_dmb_drain_video(d);
-		msleep(200);
-	}
-#endif
-
 	/* Reset the tuner */
 	if (cxusb_d680_dmb_gpio_tuner(d, 0x07, 0) < 0) {
 		err("clear tuner gpio failed");

                 reply	other threads:[~2009-11-28 11:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B110B3A.3030401@gmail.com \
    --to=davidtlwong@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox