From: "Németh Márton" <nm127@freemail.hu>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] gspca sunplus: propagate error for higher level
Date: Sun, 29 Nov 2009 13:15:37 +0100 [thread overview]
Message-ID: <4B1265E9.1040505@freemail.hu> (raw)
In-Reply-To: <20091128191717.5164a003@tele>
Jean-Francois Moine wrote:
> On Sat, 28 Nov 2009 08:13:05 +0100
> Németh Márton <nm127@freemail.hu> wrote:
>
>> what do you think about this patch?
>
> Hi Márton,
>
> There are many other drivers where the usb_control_msg() errors are not
> tested nor propagated to higher levels. Generally, this does not matter:
> the errors are signalled at the lowest level, and they seldom occur.
> Thus, I don't think your patch is useful...
I think that the return value of the usb_control_msg() is to be evaluated.
If other drivers also not evaluating the usb_control_msg() *they* has to
be fixed.
The benefit would be that the userspace program can recognise error condition
faster and react accordingly. For example the USB device can be unplugged any
time. In this case there is no use to continue sending URBs. Otherwise the user
program thinks that everything went on correctly and the user will be surprised
how come that he or she unplugged a device and it is still working.
Regards,
Márton Németh
next prev parent reply other threads:[~2009-11-29 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 13:34 [PATCH] gspca sunplus: propagate error for higher level Németh Márton
2009-11-28 7:13 ` Németh Márton
2009-11-28 18:17 ` Jean-Francois Moine
2009-11-29 12:15 ` Németh Márton [this message]
2009-11-29 17:15 ` Jean-Francois Moine
2009-11-30 14:40 ` Markus Rechberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1265E9.1040505@freemail.hu \
--to=nm127@freemail.hu \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox