From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 00/11] add linux driver for chip TLG2300
Date: Wed, 09 Dec 2009 17:08:27 -0200 [thread overview]
Message-ID: <4B1FF5AB.30405@redhat.com> (raw)
In-Reply-To: <1258687493-4012-1-git-send-email-shijie8@gmail.com>
Huang Shijie wrote:
> The TLG2300 is a chip of Telegent System.
> It support analog tv,DVB-T and radio in a single chip.
> The chip has been used in several dongles, such as aeromax DH-9000:
> http://www.b2bdvb.com/dh-9000.htm
>
> You can get more info from:
> [1] http://www.telegent.com/
> [2] http://www.telegent.com/press/2009Sept14_CSI.html
>
> Huang Shijie (10):
> add maitainers for tlg2300
> add readme file for tlg2300
> add Kconfig and Makefile for tlg2300
> add header files for tlg2300
> add the generic file
> add video file for tlg2300
> add vbi code for tlg2300
> add audio support for tlg2300
> add DVB-T support for tlg2300
> add FM support for tlg2300
>
Ok, finished reviewing it.
Patches 01, 02 and 04 seems ok to me. You didn't sent a patch 03.
Patch 05 will likely need some changes (the headers) due to some reviews I did
on the other patches.
The other patches need some adjustments, as commented on separate emails.
Cheers,
Mauro.
next prev parent reply other threads:[~2009-12-09 19:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 3:24 [PATCH 00/11] add linux driver for chip TLG2300 Huang Shijie
2009-11-20 3:24 ` [PATCH 01/11] modify video's Kconfig and Makefile for tlg2300 Huang Shijie
2009-11-20 3:24 ` [PATCH 02/11] add maitainers " Huang Shijie
[not found] ` <1258687493-4012-4-git-send-email-shijie8@gmail.com>
2009-11-20 3:24 ` [PATCH 04/11] add Kconfig and Makefile " Huang Shijie
2009-11-20 3:24 ` [PATCH 05/11] add header files " Huang Shijie
2009-11-20 3:24 ` [PATCH 06/11] add the generic file Huang Shijie
2009-11-20 3:24 ` [PATCH 07/11] add video file for tlg2300 Huang Shijie
2009-11-20 3:24 ` [PATCH 08/11] add vbi code " Huang Shijie
2009-11-20 3:24 ` [PATCH 09/11] add audio support " Huang Shijie
2009-11-20 3:24 ` [PATCH 10/11] add DVB-T " Huang Shijie
2009-11-20 3:24 ` [PATCH 11/11] add FM " Huang Shijie
2009-12-09 19:04 ` Mauro Carvalho Chehab
2009-12-09 18:56 ` [PATCH 10/11] add DVB-T " Mauro Carvalho Chehab
2009-12-09 18:52 ` [PATCH 09/11] add audio " Mauro Carvalho Chehab
2009-12-09 18:51 ` [PATCH 08/11] add vbi code " Mauro Carvalho Chehab
2009-12-09 18:48 ` [PATCH 07/11] add video file " Mauro Carvalho Chehab
2009-11-23 3:25 ` [PATCH 06/11] add the generic file Huang Shijie
2009-12-09 18:12 ` Mauro Carvalho Chehab
2009-12-09 19:08 ` Mauro Carvalho Chehab [this message]
2010-01-11 13:24 ` [PATCH 00/11] add linux driver for chip TLG2300 Mauro Carvalho Chehab
2010-01-12 1:52 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1FF5AB.30405@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox