From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from mail01a.mail.t-online.hu ([84.2.40.6]:57530 "EHLO
	mail01a.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756258AbZLLLPC (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Sat, 12 Dec 2009 06:15:02 -0500
Message-ID: <4B237B36.2030609@freemail.hu>
Date: Sat, 12 Dec 2009 12:15:02 +0100
From: =?ISO-8859-1?Q?N=E9meth_M=E1rton?= <nm127@freemail.hu>
MIME-Version: 1.0
To: Jean-Francois Moine <moinejf@free.fr>
CC: V4L Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] gspca m5602: eliminate sparse warnings
References: <4B22BAB0.5070604@freemail.hu> <20091212112145.228bb01c@tele>
In-Reply-To: <20091212112145.228bb01c@tele>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

Jean-Francois Moine wrote:
> On Fri, 11 Dec 2009 22:33:36 +0100
> Németh Márton <nm127@freemail.hu> wrote:
> 
>> From: Márton Németh <nm127@freemail.hu>
>>
>> Eliminate the following sparse warnings (see "make C=1"):
>>  * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
>>  * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y
>>
>> Signed-off-by: Márton Németh <nm127@freemail.hu>
>> ---
>> ../../m5602_s5k4aa_dubious.patch
>> diff -r f5662ce08663
>> linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
>> a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
>> 11 09:53:41 2009 +0100 +++
>> b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c	Fri Dec
>> 11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err =
>> m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0)
>> return err;
>> -	data = (data & 0xfe) | !val;
>> +	data = (data & 0xfe) | (val ? 0 : 1);
>>  	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
>>  	return err;
>>  }
>> @@ -572,7 +572,7 @@
>>  	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>>  	if (err < 0)
>>  		return err;
>> -	data = (data & 0xfe) | !val;
>> +	data = (data & 0xfe) | (val ? 0 : 1);
>>  	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
>>  	return err;
>>  }
> 
> Thanks, but I fixed it in an other way.

No problem as long as the warning message is removed.

Regards,

	Márton Németh