From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Jeremy Simmons <jeremy@impactmoto.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Douglas Landgraf <dougsland@gmail.com>
Subject: Re: Compile Error - ir-keytable
Date: Mon, 14 Dec 2009 09:53:37 -0200 [thread overview]
Message-ID: <4B262741.8050107@redhat.com> (raw)
In-Reply-To: <A8BEBCEF90A5AC498E0DAEADEBB06AD7EA9C2BEB08@DC.impactmoto.com>
Jeremy Simmons wrote:
> I'm having the same problem. Any solution?
The new IR keycode is not compatible with any kernel older than 2.6.22. Also, newer
versions may even require latter codes, due to the sysfs code.
The fix is simple:
- Don't compile any code from ir-sysfs.c with older kernels;
- Don't implement EVIO[G|S]KEYCODE ioctls;
- Replace the new code to get a key by an old code at ir-keytable.c,
if kernels <= 2.6.22.
There's nothing reasonable that we can do to support keycode replacements
with older kernels, as the scancode tables were expanded to 16 bits (and
will probably be expanded to 32 or 64 bits), and, with the legacy kernels,
the scancode/keycode table needs to be an array of the size of the scancode space.
So, a keycode table for 32 bits would waste 4Gb of ram (while we're still using
16 bits, the table won't be that big, but as we expect to soon support
RC6 protocols, it is not worth to port a code for 16 bits that will just
be dropped in a month or two).
Due to that, the support for < 2.6.22 kernels will provide a limited IR
code, after the backport: just the bundled IR will work.
I asked Douglas to do this backport after I finish the main changes at the module.
He'll likely start looking on it soon, as I've merged late yesterday the changes.
>
> -Jeremy
>
>
>
>
> ________________________________________
> * Subject: Compile Error - ir-keytable
> * From: David Carlo <dcarlo@xxxxxxxxxxxx>
> * Date: Wed, 2 Dec 2009 11:56:22 -0500
> ________________________________________
> Hello. I'm compiling the v4l kernel drivers in an attempt to use my hdpvr
> with CentOS 5.4. When I compile v4l, I'm getting this error:
>
> =============================================================================
> <snip>
> CC [M] /usr/local/src/v4l-dvb/v4l/ir-functions.o
> CC [M] /usr/local/src/v4l-dvb/v4l/ir-keymaps.o
> CC [M] /usr/local/src/v4l-dvb/v4l/ir-keytable.o
> /usr/local/src/v4l-dvb/v4l/ir-keytable.c: In function
> 'ir_g_keycode_from_table':
> /usr/local/src/v4l-dvb/v4l/ir-keytable.c:181: error: implicit declaration of
> function 'input_get_drvdata'
> /usr/local/src/v4l-dvb/v4l/ir-keytable.c:181: warning: initialization makes
> pointer from integer without a cast
> /usr/local/src/v4l-dvb/v4l/ir-keytable.c: In function 'ir_input_free':
> /usr/local/src/v4l-dvb/v4l/ir-keytable.c:236: warning: initialization makes
> pointer from integer without a cast
> make[3]: *** [/usr/local/src/v4l-dvb/v4l/ir-keytable.o] Error 1
> make[2]: *** [_module_/usr/local/src/v4l-dvb/v4l] Error 2
> make[2]: Leaving directory `/usr/src/kernels/2.6.18-164.6.1.el5-x86_64'
> make[1]: *** [default] Error 2
> make[1]: Leaving directory `/usr/local/src/v4l-dvb/v4l'
> make: *** [all] Error 2
> =============================================================================
>
> Here are the stats on my box:
> CentOS 5.4 x86_64
> kernel 2.6.18-164.6.1.el5-x86_64
> gcc 4.1.2
>
> Has anyone else seen this?
>
> --Dave
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-14 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 10:16 Compile Error - ir-keytable Jeremy Simmons
2009-12-14 11:53 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-02 16:56 David Carlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B262741.8050107@redhat.com \
--to=mchehab@redhat.com \
--cc=dougsland@gmail.com \
--cc=jeremy@impactmoto.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox