* [PATCH] lgdt3305: make one-bit bitfields unsigned
@ 2009-12-15 20:52 Németh Márton
2009-12-15 22:23 ` Michael Krufky
0 siblings, 1 reply; 2+ messages in thread
From: Németh Márton @ 2009-12-15 20:52 UTC (permalink / raw)
To: Michael Krufky, V4L Mailing List
From: Márton Németh <nm127@freemail.hu>
Make one-bit bitfields unsigned which will remove the following
sparse warning messages (see "make C=1"):
* lgdt3305.h:57:21: error: dubious one-bit signed bitfield
* lgdt3305.h:60:26: error: dubious one-bit signed bitfield
* lgdt3305.h:63:19: error: dubious one-bit signed bitfield
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r ba8d6bf077aa linux/drivers/media/dvb/frontends/lgdt3305.h
--- a/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 17:40:44 2009 +0100
+++ b/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 21:47:53 2009 +0100
@@ -54,13 +54,13 @@
u16 usref_qam256; /* default: 0x2a80 */
/* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
- int deny_i2c_rptr:1;
+ unsigned int deny_i2c_rptr:1;
/* spectral inversion - 0:disabled 1:enabled */
- int spectral_inversion:1;
+ unsigned int spectral_inversion:1;
/* use RF AGC loop - 0:disabled 1:enabled */
- int rf_agc_loop:1;
+ unsigned int rf_agc_loop:1;
enum lgdt3305_mpeg_mode mpeg_mode;
enum lgdt3305_tp_clock_edge tpclk_edge;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lgdt3305: make one-bit bitfields unsigned
2009-12-15 20:52 [PATCH] lgdt3305: make one-bit bitfields unsigned Németh Márton
@ 2009-12-15 22:23 ` Michael Krufky
0 siblings, 0 replies; 2+ messages in thread
From: Michael Krufky @ 2009-12-15 22:23 UTC (permalink / raw)
To: Németh Márton; +Cc: V4L Mailing List
Thanks -- I'll push this in through the lgdt3305 repository... I'll send
in a pull request to Mauro shortly.
-Mike
Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> Make one-bit bitfields unsigned which will remove the following
> sparse warning messages (see "make C=1"):
> * lgdt3305.h:57:21: error: dubious one-bit signed bitfield
> * lgdt3305.h:60:26: error: dubious one-bit signed bitfield
> * lgdt3305.h:63:19: error: dubious one-bit signed bitfield
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff -r ba8d6bf077aa linux/drivers/media/dvb/frontends/lgdt3305.h
> --- a/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 17:40:44 2009 +0100
> +++ b/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 21:47:53 2009 +0100
> @@ -54,13 +54,13 @@
> u16 usref_qam256; /* default: 0x2a80 */
>
> /* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
> - int deny_i2c_rptr:1;
> + unsigned int deny_i2c_rptr:1;
>
> /* spectral inversion - 0:disabled 1:enabled */
> - int spectral_inversion:1;
> + unsigned int spectral_inversion:1;
>
> /* use RF AGC loop - 0:disabled 1:enabled */
> - int rf_agc_loop:1;
> + unsigned int rf_agc_loop:1;
>
> enum lgdt3305_mpeg_mode mpeg_mode;
> enum lgdt3305_tp_clock_edge tpclk_edge;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-15 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 20:52 [PATCH] lgdt3305: make one-bit bitfields unsigned Németh Márton
2009-12-15 22:23 ` Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox