From: Michael Krufky <mkrufky@linuxtv.org>
To: "Németh Márton" <nm127@freemail.hu>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] lgdt3305: make one-bit bitfields unsigned
Date: Tue, 15 Dec 2009 17:23:46 -0500 [thread overview]
Message-ID: <4B280C72.1030908@linuxtv.org> (raw)
In-Reply-To: <4B27F6F3.5000300@freemail.hu>
Thanks -- I'll push this in through the lgdt3305 repository... I'll send
in a pull request to Mauro shortly.
-Mike
Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> Make one-bit bitfields unsigned which will remove the following
> sparse warning messages (see "make C=1"):
> * lgdt3305.h:57:21: error: dubious one-bit signed bitfield
> * lgdt3305.h:60:26: error: dubious one-bit signed bitfield
> * lgdt3305.h:63:19: error: dubious one-bit signed bitfield
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff -r ba8d6bf077aa linux/drivers/media/dvb/frontends/lgdt3305.h
> --- a/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 17:40:44 2009 +0100
> +++ b/linux/drivers/media/dvb/frontends/lgdt3305.h Tue Dec 15 21:47:53 2009 +0100
> @@ -54,13 +54,13 @@
> u16 usref_qam256; /* default: 0x2a80 */
>
> /* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
> - int deny_i2c_rptr:1;
> + unsigned int deny_i2c_rptr:1;
>
> /* spectral inversion - 0:disabled 1:enabled */
> - int spectral_inversion:1;
> + unsigned int spectral_inversion:1;
>
> /* use RF AGC loop - 0:disabled 1:enabled */
> - int rf_agc_loop:1;
> + unsigned int rf_agc_loop:1;
>
> enum lgdt3305_mpeg_mode mpeg_mode;
> enum lgdt3305_tp_clock_edge tpclk_edge;
>
prev parent reply other threads:[~2009-12-15 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 20:52 [PATCH] lgdt3305: make one-bit bitfields unsigned Németh Márton
2009-12-15 22:23 ` Michael Krufky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B280C72.1030908@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=linux-media@vger.kernel.org \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox