public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: OK
@ 2010-01-03 19:50 Hans Verkuil
  2010-01-03 20:34 ` [PATCH] rj54n1cb0c: remove compiler warning Németh Márton
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2010-01-03 19:50 UTC (permalink / raw)
  To: linux-media

This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.

Results of the daily build of v4l-dvb:

date:        Sun Jan  3 19:00:03 CET 2010
path:        http://www.linuxtv.org/hg/v4l-dvb
changeset:   13879:b6b82258cf5e
gcc version: gcc (GCC) 4.3.1
hardware:    x86_64
host os:     2.6.26

linux-2.6.30-armv5: OK
linux-2.6.31-armv5: OK
linux-2.6.32-armv5: OK
linux-2.6.33-rc2-armv5: ERRORS
linux-2.6.32-armv5-davinci: OK
linux-2.6.33-rc2-armv5-davinci: ERRORS
linux-2.6.30-armv5-ixp: OK
linux-2.6.31-armv5-ixp: OK
linux-2.6.32-armv5-ixp: OK
linux-2.6.33-rc2-armv5-ixp: ERRORS
linux-2.6.30-armv5-omap2: OK
linux-2.6.31-armv5-omap2: OK
linux-2.6.32-armv5-omap2: OK
linux-2.6.33-rc2-armv5-omap2: ERRORS
linux-2.6.22.19-i686: OK
linux-2.6.23.12-i686: OK
linux-2.6.24.7-i686: OK
linux-2.6.25.11-i686: OK
linux-2.6.26-i686: OK
linux-2.6.27-i686: OK
linux-2.6.28-i686: OK
linux-2.6.29.1-i686: WARNINGS
linux-2.6.30-i686: OK
linux-2.6.31-i686: WARNINGS
linux-2.6.32-i686: WARNINGS
linux-2.6.33-rc2-i686: ERRORS
linux-2.6.30-m32r: OK
linux-2.6.31-m32r: OK
linux-2.6.32-m32r: OK
linux-2.6.33-rc2-m32r: ERRORS
linux-2.6.30-mips: WARNINGS
linux-2.6.31-mips: OK
linux-2.6.32-mips: OK
linux-2.6.33-rc2-mips: ERRORS
linux-2.6.30-powerpc64: WARNINGS
linux-2.6.31-powerpc64: OK
linux-2.6.32-powerpc64: WARNINGS
linux-2.6.33-rc2-powerpc64: ERRORS
linux-2.6.22.19-x86_64: OK
linux-2.6.23.12-x86_64: OK
linux-2.6.24.7-x86_64: OK
linux-2.6.25.11-x86_64: OK
linux-2.6.26-x86_64: OK
linux-2.6.27-x86_64: OK
linux-2.6.28-x86_64: OK
linux-2.6.29.1-x86_64: WARNINGS
linux-2.6.30-x86_64: OK
linux-2.6.31-x86_64: WARNINGS
linux-2.6.32-x86_64: WARNINGS
linux-2.6.33-rc2-x86_64: ERRORS
spec: OK
sparse (linux-2.6.32): ERRORS
sparse (linux-2.6.33-rc2): ERRORS
linux-2.6.16.61-i686: OK
linux-2.6.17.14-i686: OK
linux-2.6.18.8-i686: OK
linux-2.6.19.5-i686: OK
linux-2.6.20.21-i686: OK
linux-2.6.21.7-i686: OK
linux-2.6.16.61-x86_64: OK
linux-2.6.17.14-x86_64: OK
linux-2.6.18.8-x86_64: OK
linux-2.6.19.5-x86_64: OK
linux-2.6.20.21-x86_64: OK
linux-2.6.21.7-x86_64: OK

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2

The V4L-DVB specification from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] rj54n1cb0c: remove compiler warning
  2010-01-03 19:50 [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: OK Hans Verkuil
@ 2010-01-03 20:34 ` Németh Márton
  2010-01-04 21:01   ` Guennadi Liakhovetski
  0 siblings, 1 reply; 4+ messages in thread
From: Németh Márton @ 2010-01-03 20:34 UTC (permalink / raw)
  To: Guennadi Liakhovetski; +Cc: Hans Verkuil, V4L Mailing List

From: Márton Németh <nm127@freemail.hu>

Remove the following compiler warning: 'dummy' is used uninitialized in this function.
Although the result in the dummy variable is not used the program flow in
soc_camera_limit_side() depends on the value in dummy. The program flow is better
to be deterministic.

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c
--- a/linux/drivers/media/video/rj54n1cb0c.c	Wed Dec 30 18:19:11 2009 +0100
+++ b/linux/drivers/media/video/rj54n1cb0c.c	Sun Jan 03 21:30:20 2010 +0100
@@ -563,7 +563,7 @@
 	struct i2c_client *client = sd->priv;
 	struct rj54n1 *rj54n1 = to_rj54n1(client);
 	struct v4l2_rect *rect = &a->c;
-	unsigned int dummy, output_w, output_h,
+	unsigned int dummy = 0, output_w, output_h,
 		input_w = rect->width, input_h = rect->height;
 	int ret;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rj54n1cb0c: remove compiler warning
  2010-01-03 20:34 ` [PATCH] rj54n1cb0c: remove compiler warning Németh Márton
@ 2010-01-04 21:01   ` Guennadi Liakhovetski
  2010-01-04 21:10     ` Németh Márton
  0 siblings, 1 reply; 4+ messages in thread
From: Guennadi Liakhovetski @ 2010-01-04 21:01 UTC (permalink / raw)
  To: Németh Márton; +Cc: Hans Verkuil, V4L Mailing List

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1412 bytes --]

Hi Márton

On Sun, 3 Jan 2010, Németh Márton wrote:

> From: Márton Németh <nm127@freemail.hu>
> 
> Remove the following compiler warning: 'dummy' is used uninitialized in this function.
> Although the result in the dummy variable is not used the program flow in
> soc_camera_limit_side() depends on the value in dummy. The program flow is better
> to be deterministic.
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>

The patch is good, the only slight problem - you have non-ASCII characters 
in your name and you didn't use UTF-8 to send this mail, which, I think, 
is the accepted encoding in the Linux kernel. I converted your patch to 
utf8 and attached to this mail. Please verify that the result is correct.

> ---
> diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c
> --- a/linux/drivers/media/video/rj54n1cb0c.c	Wed Dec 30 18:19:11 2009 +0100
> +++ b/linux/drivers/media/video/rj54n1cb0c.c	Sun Jan 03 21:30:20 2010 +0100
> @@ -563,7 +563,7 @@
>  	struct i2c_client *client = sd->priv;
>  	struct rj54n1 *rj54n1 = to_rj54n1(client);
>  	struct v4l2_rect *rect = &a->c;
> -	unsigned int dummy, output_w, output_h,
> +	unsigned int dummy = 0, output_w, output_h,
>  		input_w = rect->width, input_h = rect->height;
>  	int ret;
> 

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

[-- Attachment #2: Type: TEXT/x-diff, Size: 1208 bytes --]

From nm127@freemail.hu Sun Jan  3 21:38:51 2010
Date: Sun, 03 Jan 2010 21:34:59 +0100
From: Németh Márton <nm127@freemail.hu>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] rj54n1cb0c: remove compiler warning

From: Márton Németh <nm127@freemail.hu>

Remove the following compiler warning: 'dummy' is used uninitialized in this function.
Although the result in the dummy variable is not used the program flow in
soc_camera_limit_side() depends on the value in dummy. The program flow is better
to be deterministic.

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c
--- a/linux/drivers/media/video/rj54n1cb0c.c	Wed Dec 30 18:19:11 2009 +0100
+++ b/linux/drivers/media/video/rj54n1cb0c.c	Sun Jan 03 21:30:20 2010 +0100
@@ -563,7 +563,7 @@
 	struct i2c_client *client = sd->priv;
 	struct rj54n1 *rj54n1 = to_rj54n1(client);
 	struct v4l2_rect *rect = &a->c;
-	unsigned int dummy, output_w, output_h,
+	unsigned int dummy = 0, output_w, output_h,
 		input_w = rect->width, input_h = rect->height;
 	int ret;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rj54n1cb0c: remove compiler warning
  2010-01-04 21:01   ` Guennadi Liakhovetski
@ 2010-01-04 21:10     ` Németh Márton
  0 siblings, 0 replies; 4+ messages in thread
From: Németh Márton @ 2010-01-04 21:10 UTC (permalink / raw)
  To: Guennadi Liakhovetski; +Cc: Hans Verkuil, V4L Mailing List

Guennadi Liakhovetski wrote:
> Hi Márton
> 
> On Sun, 3 Jan 2010, Németh Márton wrote:
> 
>> From: Márton Németh <nm127@freemail.hu>
>>
>> Remove the following compiler warning: 'dummy' is used uninitialized in this function.
>> Although the result in the dummy variable is not used the program flow in
>> soc_camera_limit_side() depends on the value in dummy. The program flow is better
>> to be deterministic.
>>
>> Signed-off-by: Márton Németh <nm127@freemail.hu>
> 
> The patch is good, the only slight problem - you have non-ASCII characters 
> in your name and you didn't use UTF-8 to send this mail, which, I think, 
> is the accepted encoding in the Linux kernel. I converted your patch to 
> utf8 and attached to this mail. Please verify that the result is correct.

Your conversion is OK. Sorry about this issue.

Regards,

	Márton Németh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-01-04 21:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-03 19:50 [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: OK Hans Verkuil
2010-01-03 20:34 ` [PATCH] rj54n1cb0c: remove compiler warning Németh Márton
2010-01-04 21:01   ` Guennadi Liakhovetski
2010-01-04 21:10     ` Németh Márton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox