From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail02a.mail.t-online.hu ([84.2.40.7]:59320 "EHLO mail02a.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715Ab0AJMn1 (ORCPT ); Sun, 10 Jan 2010 07:43:27 -0500 Message-ID: <4B49CB69.70708@freemail.hu> Date: Sun, 10 Jan 2010 13:43:21 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Jean-Francois Moine , Hans de Goede , V4L Mailing List Subject: Re: [PATCH 2/2] gspca pac7302: add support for camera button References: <4B095EEF.9070205@freemail.hu> <4B49C3E6.2040206@infradead.org> <4B49C70E.90109@freemail.hu> <4B49CA0F.3040502@infradead.org> In-Reply-To: <4B49CA0F.3040502@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: Mauro Carvalho Chehab írta: > Németh Márton wrote: >> Mauro Carvalho Chehab worte: >>> Németh Márton wrote: >>>> From: Márton Németh >>>> >>>> Add support for snapshot button found on Labtec Webcam 2200 >>>> (USB ID 093a:2626 >>> This patch breaks compilation against current -tip: >> There was several versions of adding support to pac7302. The last version >> still have some problems which I haven't addressed, yet. So the camera >> button support for pac7302 is not yet ready for inclusion. > > Ok. While you don't have a final version, please add an "RFC" at the patch, for > me to know, when dealing with patchwork queue, that the patch is not ok > yet. I thought every time it was the final version ;-), but I get some comments which may make the code quality and acceptance better. Regards, Márton Németh