From: Jiri Slaby <jirislaby@gmail.com>
To: Andy Walls <awalls@radix.net>
Cc: mchehab@redhat.com, hverkuil@xs4all.nl,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] media: video/cx18, fix potential null dereference
Date: Tue, 12 Jan 2010 12:28:47 +0100 [thread overview]
Message-ID: <4B4C5CEF.5060601@gmail.com> (raw)
In-Reply-To: <1263253709.4116.1.camel@palomino.walls.org>
On 01/12/2010 12:48 AM, Andy Walls wrote:
> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote:
>> Stanse found a potential null dereference in cx18_dvb_start_feed
>> and cx18_dvb_stop_feed. There is a check for stream being NULL,
>> but it is dereferenced earlier. Move the dereference after the
>> check.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>
> Reviewed-by: Andy Walls <awalls@radix.net>
> Acked-by: Andy Walls <awalls@radix.net>
You definitely know the code better, have you checked that it can happen
at all? I mean may demux->priv be NULL?
next prev parent reply other threads:[~2010-01-12 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 8:56 [PATCH 1/1] media: video/cx18, fix potential null dereference Jiri Slaby
2010-01-11 23:48 ` Andy Walls
2010-01-12 11:28 ` Jiri Slaby [this message]
2010-01-13 11:32 ` Andy Walls
2010-01-13 11:35 ` Jiri Slaby
2010-01-13 11:43 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4C5CEF.5060601@gmail.com \
--to=jirislaby@gmail.com \
--cc=awalls@radix.net \
--cc=hverkuil@xs4all.nl \
--cc=ivtv-devel@ivtvdriver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox