public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: TJ <one.timothy.jones@gmail.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: go7007 driver -- which program you use for capture
Date: Wed, 13 Jan 2010 19:02:10 -0200	[thread overview]
Message-ID: <4B4E34D2.8090202@redhat.com> (raw)
In-Reply-To: <4B47B0EB.6000102@gmail.com>

TJ wrote:
> jelle, that you?
> 
> Here's the patch against go7007 driver in 2.6.32 kernel (run with -p1).
> 
> The main purpose of the patch is to include support for ADS Tech DVD Xpress DX2
> usb capture card and make it usable with v4l2-ctl utility.
> 
> I also did a general clean-up in a few areas and *temporarily* added back in
> proprietary go7007 ioctls, so current mythtv users can take advantage of it and
> to make the gorecord program from wis-go7007 package now work again.
> 
> Also attached is a stripped down version of gorecord from which I removed all
> parameter-setting stuff. This version is meant to be used in conjunction with
> v4l2-ctl or other means of configuring capture parameters.
> 
> I will try to do mythtv patches next so that it starts using standard v4l2 ioctl
> calls and we can drop all proprietary stuff in the driver.
> 
> Please try it and lemme know if it works for you. I've run into a few Ubuntuers
> as well who were trying to get their boards working as well.

The patch doesn't apply on the latest -hg version:
patching file drivers/staging/go7007/Kconfig
patching file drivers/staging/go7007/go7007-driver.c
Hunk #2 succeeded at 225 (offset 1 line).
Hunk #3 succeeded at 285 (offset 1 line).
patching file drivers/staging/go7007/go7007-usb.c
patching file drivers/staging/go7007/go7007-v4l2.c
Hunk #1 FAILED at 43.
Hunk #2 succeeded at 425 with fuzz 2 (offset 8 lines).
Hunk #4 succeeded at 578 (offset 8 lines).
Hunk #6 FAILED at 993.
Hunk #7 succeeded at 1078 with fuzz 1 (offset -8 lines).
Hunk #8 FAILED at 1538.
Hunk #9 succeeded at 1672 (offset -18 lines).
Hunk #10 succeeded at 1764 (offset -8 lines).
3 out of 10 hunks FAILED -- saving rejects to file drivers/staging/go7007/go7007-v4l2.c.rej
patching file drivers/staging/go7007/s2250-board.c
Hunk #1 FAILED at 357.
1 out of 1 hunk FAILED -- saving rejects to file drivers/staging/go7007/s2250-board.c.rej
patching file drivers/staging/go7007/wis-i2c.h
patching file drivers/staging/go7007/wis-saa7113.c
patching file drivers/staging/go7007/wis-saa7115.c
patching file drivers/staging/go7007/wis-tw2804.c
patching file drivers/staging/go7007/wis-tw9903.c
Hunk #1 FAILED at 152.
1 out of 1 hunk FAILED -- saving rejects to file drivers/staging/go7007/wis-tw9903.c.rej
patching file drivers/staging/go7007/wis-tw9906.c
Patch doesn't apply

Also, you shouldn't re-add the proprietary API but, instead, to port it to use the
API support for compressed stuff.

Cheers,
Mauro.


  reply	other threads:[~2010-01-13 21:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08 19:07 go7007 driver -- which program you use for capture TJ
2010-01-08 20:17 ` Jarod Wilson
2010-01-08 22:25   ` TJ
2010-01-13 21:02     ` Mauro Carvalho Chehab [this message]
2010-01-13 22:04       ` TJ
2010-01-13 22:12         ` Mauro Carvalho Chehab
2010-01-14 20:03           ` TJ
2010-01-14 20:08             ` Pete Eberlein
2010-01-14 20:18               ` TJ
2010-01-12 23:46 ` Pete Eberlein
2010-01-13 21:51   ` TJ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4E34D2.8090202@redhat.com \
    --to=mchehab@redhat.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-media@vger.kernel.org \
    --cc=one.timothy.jones@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox