From: Michael Trimarchi <michael@panicking.kicks-ass.org>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: omap34xxcam question?
Date: Thu, 14 Jan 2010 18:25:15 +0100 [thread overview]
Message-ID: <4B4F537B.7000708@panicking.kicks-ass.org> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894451538FFB@dlee02.ent.ti.com>
Hi,
Aguirre, Sergio wrote:
>
>> -----Original Message-----
>> From: Michael Trimarchi [mailto:michael@panicking.kicks-ass.org]
>> Sent: Thursday, January 14, 2010 6:01 AM
>> To: linux-media@vger.kernel.org
>> Cc: Aguirre, Sergio
>> Subject: omap34xxcam question?
>>
>> Hi
>>
>> Is ok that it try only the first format and size? why does it not continue
>> and find a matching?
>
> Actually, that was the intention, but I guess it was badly implemented.
>
> Thanks for the catch, and the contribution!
>
> Regards,
> Sergio
>> @@ -470,7 +471,7 @@ static int try_pix_parm(struct omap34xxcam_videodev
>> *vdev,
>> pix_tmp_out = *wanted_pix_out;
>> rval = isp_try_fmt_cap(isp, &pix_tmp_in,
>> &pix_tmp_out);
>> if (rval)
>> - return rval;
>> + continue;
>>
Is the patch good? or you are going to provide a better fix
Michael
>> Michael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-01-14 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 12:00 omap34xxcam question? Michael Trimarchi
2010-01-14 17:09 ` Aguirre, Sergio
2010-01-14 17:25 ` Michael Trimarchi [this message]
2010-01-14 17:33 ` Aguirre, Sergio
2010-01-14 17:39 ` Michael Trimarchi
2010-01-14 19:08 ` [RFC PATCH] fix try_pix_parm loop Michael Trimarchi
2010-01-14 23:57 ` omap34xxcam question? Aguirre, Sergio
2010-01-15 8:38 ` Michael Trimarchi
2010-01-19 17:30 ` Michael Trimarchi
2010-02-04 14:21 ` Sakari Ailus
2010-02-04 15:06 ` Michael Trimarchi
2010-02-05 7:43 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F537B.7000708@panicking.kicks-ass.org \
--to=michael@panicking.kicks-ass.org \
--cc=linux-media@vger.kernel.org \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox