public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* V4L/DVB ivtv-yuv.c: args->dst.left assigned to both nf->tru_x and nf->dst_x in ivtv_yuv_setup_frame()
@ 2010-01-15 14:41 Roel Kluin
  2010-01-15 16:06 ` Ian Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-15 14:41 UTC (permalink / raw)
  To: Hans Verkuil, ivtv-devel, linux-media

vi drivers/media/video/ivtv/ivtv-yuv.c +971

and note that `args->dst.left' is assigned both to
nf->tru_x and nf->dst_x, is that ok?

Roel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: V4L/DVB ivtv-yuv.c: args->dst.left assigned to both nf->tru_x and nf->dst_x in ivtv_yuv_setup_frame()
  2010-01-15 14:41 V4L/DVB ivtv-yuv.c: args->dst.left assigned to both nf->tru_x and nf->dst_x in ivtv_yuv_setup_frame() Roel Kluin
@ 2010-01-15 16:06 ` Ian Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Armstrong @ 2010-01-15 16:06 UTC (permalink / raw)
  To: Roel Kluin; +Cc: Hans Verkuil, ivtv-devel, linux-media

On Friday 15 January 2010, Roel Kluin wrote:
> vi drivers/media/video/ivtv/ivtv-yuv.c +971
> 
> and note that `args->dst.left' is assigned both to
> nf->tru_x and nf->dst_x, is that ok?

It's fine. dst_x is used to set a hardware register and may be changed in 
ivtv_yuv_window_setup()

tru_x is never altered & is used in a special condition where the original 
unaltered value is required.

-- 
Ian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-15 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15 14:41 V4L/DVB ivtv-yuv.c: args->dst.left assigned to both nf->tru_x and nf->dst_x in ivtv_yuv_setup_frame() Roel Kluin
2010-01-15 16:06 ` Ian Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox