* [PATCH] cx231xx: cleanup dvb_attach() return value handling
@ 2010-01-16 16:21 Németh Márton
0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-16 16:21 UTC (permalink / raw)
To: Srinivasa Deevi; +Cc: V4L Mailing List
From: Márton Németh <nm127@freemail.hu>
Remove the following sparse error (see "make C=1"):
* error: incompatible types for operation (<)
left side has type struct dvb_frontend *
right side has type int
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 5bcdcc072b6d linux/drivers/media/video/cx231xx/cx231xx-dvb.c
--- a/linux/drivers/media/video/cx231xx/cx231xx-dvb.c Sat Jan 16 07:25:43 2010 +0100
+++ b/linux/drivers/media/video/cx231xx/cx231xx-dvb.c Sat Jan 16 17:21:06 2010 +0100
@@ -465,9 +465,9 @@
/* define general-purpose callback pointer */
dvb->frontend->callback = cx231xx_tuner_callback;
- if (dvb_attach(xc5000_attach, dev->dvb->frontend,
+ if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
&dev->i2c_bus[1].i2c_adap,
- &cnxt_rde250_tunerconfig) < 0) {
+ &cnxt_rde250_tunerconfig)) {
result = -EINVAL;
goto out_free;
}
@@ -487,9 +487,9 @@
/* define general-purpose callback pointer */
dvb->frontend->callback = cx231xx_tuner_callback;
- if (dvb_attach(xc5000_attach, dev->dvb->frontend,
+ if (!dvb_attach(xc5000_attach, dev->dvb->frontend,
&dev->i2c_bus[1].i2c_adap,
- &cnxt_rde250_tunerconfig) < 0) {
+ &cnxt_rde250_tunerconfig)) {
result = -EINVAL;
goto out_free;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-16 16:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-16 16:21 [PATCH] cx231xx: cleanup dvb_attach() return value handling Németh Márton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox