* [PATCH] cx23885: Wrong command printed in cmd_to_str()
@ 2010-01-20 0:47 Roel Kluin
2010-01-20 13:00 ` Steven Toth
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-20 0:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media, Andrew Morton, LKML
The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE,
and a typo in case CX2341X_ENC_SET_PCR_ID.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Or is this intended?
diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index 88c0d24..2ab97ad 100644
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -681,7 +681,7 @@ static char *cmd_to_str(int cmd)
case CX2341X_ENC_SET_VIDEO_ID:
return "SET_VIDEO_ID";
case CX2341X_ENC_SET_PCR_ID:
- return "SET_PCR_PID";
+ return "SET_PCR_ID";
case CX2341X_ENC_SET_FRAME_RATE:
return "SET_FRAME_RATE";
case CX2341X_ENC_SET_FRAME_SIZE:
@@ -693,7 +693,7 @@ static char *cmd_to_str(int cmd)
case CX2341X_ENC_SET_ASPECT_RATIO:
return "SET_ASPECT_RATIO";
case CX2341X_ENC_SET_DNR_FILTER_MODE:
- return "SET_DNR_FILTER_PROPS";
+ return "SET_DNR_FILTER_MODE";
case CX2341X_ENC_SET_DNR_FILTER_PROPS:
return "SET_DNR_FILTER_PROPS";
case CX2341X_ENC_SET_CORING_LEVELS:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cx23885: Wrong command printed in cmd_to_str()
2010-01-20 0:47 [PATCH] cx23885: Wrong command printed in cmd_to_str() Roel Kluin
@ 2010-01-20 13:00 ` Steven Toth
0 siblings, 0 replies; 2+ messages in thread
From: Steven Toth @ 2010-01-20 13:00 UTC (permalink / raw)
To: Roel Kluin; +Cc: Mauro Carvalho Chehab, linux-media, Andrew Morton, LKML
Thanks Roel.
Acked-By: Steven Toth <stoth@kernellabs.com>
- Steve
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
On Tue, Jan 19, 2010 at 7:47 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
> The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE,
> and a typo in case CX2341X_ENC_SET_PCR_ID.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Or is this intended?
>
> diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
> index 88c0d24..2ab97ad 100644
> --- a/drivers/media/video/cx23885/cx23885-417.c
> +++ b/drivers/media/video/cx23885/cx23885-417.c
> @@ -681,7 +681,7 @@ static char *cmd_to_str(int cmd)
> case CX2341X_ENC_SET_VIDEO_ID:
> return "SET_VIDEO_ID";
> case CX2341X_ENC_SET_PCR_ID:
> - return "SET_PCR_PID";
> + return "SET_PCR_ID";
> case CX2341X_ENC_SET_FRAME_RATE:
> return "SET_FRAME_RATE";
> case CX2341X_ENC_SET_FRAME_SIZE:
> @@ -693,7 +693,7 @@ static char *cmd_to_str(int cmd)
> case CX2341X_ENC_SET_ASPECT_RATIO:
> return "SET_ASPECT_RATIO";
> case CX2341X_ENC_SET_DNR_FILTER_MODE:
> - return "SET_DNR_FILTER_PROPS";
> + return "SET_DNR_FILTER_MODE";
> case CX2341X_ENC_SET_DNR_FILTER_PROPS:
> return "SET_DNR_FILTER_PROPS";
> case CX2341X_ENC_SET_CORING_LEVELS:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-20 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 0:47 [PATCH] cx23885: Wrong command printed in cmd_to_str() Roel Kluin
2010-01-20 13:00 ` Steven Toth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox