* [PATCH] hdpvr-video: cleanup signedness
@ 2010-01-23 13:44 Németh Márton
2010-02-03 14:31 ` Janne Grunau
0 siblings, 1 reply; 2+ messages in thread
From: Németh Márton @ 2010-01-23 13:44 UTC (permalink / raw)
To: Janne Grunau; +Cc: V4L Mailing List
From: Márton Németh <nm127@freemail.hu>
The fifth parameter of usb_bulk_msg() is a pointer to signed
(see <linux/usb.h>) so also call this function with pointer to signed.
This will remove the following sparse warning (see "make C=1"):
* warning: incorrect type in argument 5 (different signedness)
expected int *actual_length
got unsigned int *<noident>
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 2a50a0a1c951 linux/drivers/media/video/hdpvr/hdpvr-video.c
--- a/linux/drivers/media/video/hdpvr/hdpvr-video.c Sat Jan 23 00:14:32 2010 -0200
+++ b/linux/drivers/media/video/hdpvr/hdpvr-video.c Sat Jan 23 11:43:17 2010 +0100
@@ -302,7 +302,8 @@
/* function expects dev->io_mutex to be hold by caller */
static int hdpvr_stop_streaming(struct hdpvr_device *dev)
{
- uint actual_length, c = 0;
+ int actual_length;
+ uint c = 0;
u8 *buf;
if (dev->status == STATUS_IDLE)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hdpvr-video: cleanup signedness
2010-01-23 13:44 [PATCH] hdpvr-video: cleanup signedness Németh Márton
@ 2010-02-03 14:31 ` Janne Grunau
0 siblings, 0 replies; 2+ messages in thread
From: Janne Grunau @ 2010-02-03 14:31 UTC (permalink / raw)
To: Németh Márton; +Cc: V4L Mailing List
On Sat, Jan 23, 2010 at 02:44:34PM +0100, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> The fifth parameter of usb_bulk_msg() is a pointer to signed
> (see <linux/usb.h>) so also call this function with pointer to signed.
>
> This will remove the following sparse warning (see "make C=1"):
> * warning: incorrect type in argument 5 (different signedness)
> expected int *actual_length
> got unsigned int *<noident>
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
Thanks, I'll send a git pull request including the second patch for Mauro
later today.
cheers Janne
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-03 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 13:44 [PATCH] hdpvr-video: cleanup signedness Németh Márton
2010-02-03 14:31 ` Janne Grunau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox