Problems with cx18

Problems with cx18

[Mauro Carvalho Chehab]

Hi Devin/Andy/Jean,

The cx88-alsa and cx18-drivers are broken: the driver depend of request_modules that doesn't exist
when !CONFIG_MODULES, and has some wrong __init annotations.

The sq905c has a warning.

I'm compiling it with:
	make ARCH=i386 allmodconfig drivers/media/|grep -v "^  CC" |grep -v "^  LD"

Those are the errors found:

drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init 
annotation or the annotation of snd_cx18_init is wrong.

WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init 
annotation or the annotation of snd_cx18_init is wrong.

drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:
drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init 
annotation or the annotation of snd_cx18_init is wrong.

WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init 
annotation or the annotation of snd_cx18_init is wrong.

Please fix.

Cheers,
Mauro.

Re: Problems with cx18

[Devin Heitmueller]

On Mon, Jan 25, 2010 at 10:06 AM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Hi Devin/Andy/Jean,
>
> The cx88-alsa and cx18-drivers are broken: the driver depend of request_modules that doesn't exist
> when !CONFIG_MODULES, and has some wrong __init annotations.
>
> The sq905c has a warning.
>
> I'm compiling it with:
>        make ARCH=i386 allmodconfig drivers/media/|grep -v "^  CC" |grep -v "^  LD"
>
> Those are the errors found:
>
> drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
> WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> The function cx18_alsa_load() references
> the function __init snd_cx18_init().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_init is wrong.
>
> WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> The function cx18_alsa_load() references
> the function __init snd_cx18_init().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_init is wrong.
>
> drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:
> drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
> WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> The function cx18_alsa_load() references
> the function __init snd_cx18_init().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_init is wrong.
>
> WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> The function cx18_alsa_load() references
> the function __init snd_cx18_init().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_init is wrong.

This looks like breakage I probably introduced with the cx18 alsa
support.  I will dig into this tonight.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Re: Problems with cx18

[Devin Heitmueller]

On Mon, Jan 25, 2010 at 11:45 AM, Theodore Kilgore
<kilgota@banach.math.auburn.edu> wrote:
>
>
> On Mon, 25 Jan 2010, Mauro Carvalho Chehab wrote:
>
>> Hi Devin/Andy/Jean,
>
> <snip>
>
>> The sq905c has a warning.
>
> <snip>
>
>> drivers/media/video/gspca/sq905c.c: In function ?sd_config?:
>> drivers/media/video/gspca/sq905c.c:207: warning: unused variable ?i?
>
> <snip>
>
>> Please fix.
>>
>> Cheers,
>> Mauro.
>
> This one has been fixed, already. A more recent version of sq905c.c is in
> the pipeline somewhere.
>
> Theodore Kilgore

Not intending to hijack this thread, but maybe it would be a good idea
for Hans's nightly rig to do a build with module support disabled on
at least one platform.  I'm not saying we should do it on all
platforms, but if we at least run it on x86 then we would spot this
class of issue earlier.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Re: Problems with cx18

[Theodore Kilgore]

On Mon, 25 Jan 2010, Mauro Carvalho Chehab wrote:

> Hi Devin/Andy/Jean,

<snip>

> The sq905c has a warning.

<snip>

> drivers/media/video/gspca/sq905c.c: In function ?sd_config?:
> drivers/media/video/gspca/sq905c.c:207: warning: unused variable ?i?

<snip>

> Please fix.
>
> Cheers,
> Mauro.

This one has been fixed, already. A more recent version of sq905c.c is in 
the pipeline somewhere.

Theodore Kilgore

Re: Problems with cx18

[Andy Walls]

On Mon, 2010-01-25 at 10:47 -0500, Devin Heitmueller wrote:
> On Mon, Jan 25, 2010 at 10:06 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
> > Hi Devin/Andy/Jean,
> >
> > The cx88-alsa and cx18-drivers are broken: the driver depend of request_modules that doesn't exist
> > when !CONFIG_MODULES, and has some wrong __init annotations.
> >
> > The sq905c has a warning.
> >
> > I'm compiling it with:
> >        make ARCH=i386 allmodconfig drivers/media/|grep -v "^  CC" |grep -v "^  LD"
> >
> > Those are the errors found:
> >
> > drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
> > WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> > The function cx18_alsa_load() references
> > the function __init snd_cx18_init().
> > This is often because cx18_alsa_load lacks a __init
> > annotation or the annotation of snd_cx18_init is wrong.
> >
> > WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> > The function cx18_alsa_load() references
> > the function __init snd_cx18_init().
> > This is often because cx18_alsa_load lacks a __init
> > annotation or the annotation of snd_cx18_init is wrong.
> >
> > drivers/media/video/gspca/sq905c.c: In function ‘sd_config’:
> > drivers/media/video/gspca/sq905c.c:207: warning: unused variable ‘i’
> > WARNING: drivers/media/video/built-in.o(.text+0x28d24e): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> > The function cx18_alsa_load() references
> > the function __init snd_cx18_init().
> > This is often because cx18_alsa_load lacks a __init
> > annotation or the annotation of snd_cx18_init is wrong.
> >
> > WARNING: drivers/media/built-in.o(.text+0x2d2a2a): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init()
> > The function cx18_alsa_load() references
> > the function __init snd_cx18_init().
> > This is often because cx18_alsa_load lacks a __init
> > annotation or the annotation of snd_cx18_init is wrong.
> 
> This looks like breakage I probably introduced with the cx18 alsa
> support.  I will dig into this tonight.

Devin,

If it's easiest to not treat the cx18-alsa stuff as a module and just
always have the cx18 ALSA device interface available, that's OK by me.
Your call.

Regards,
Andy


> Devin
>