From: "Németh Márton" <nm127@freemail.hu>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] uvcvideo: check minimum border of control
Date: Tue, 26 Jan 2010 22:37:52 +0100 [thread overview]
Message-ID: <4B5F60B0.7090709@freemail.hu> (raw)
Check also the minimum border of a value before setting it
to a control value.
See also http://bugzilla.kernel.org/show_bug.cgi?id=12824 .
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
drivers/media/video/uvc/uvc_ctrl.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -1068,6 +1068,8 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES));
xctrl->value = min + (xctrl->value - min + step/2) / step * step;
+ if (xctrl->value < min)
+ xctrl->value = min;
if (xctrl->value > max)
xctrl->value = max;
value = xctrl->value;
next reply other threads:[~2010-01-26 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 21:37 Németh Márton [this message]
2010-01-29 16:09 ` [PATCH] uvcvideo: check minimum border of control Mauro Carvalho Chehab
2010-01-29 17:03 ` Németh Márton
2010-01-29 17:06 ` Mauro Carvalho Chehab
2010-01-29 17:12 ` Németh Márton
2010-01-29 17:20 ` Mauro Carvalho Chehab
2010-02-03 0:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F60B0.7090709@freemail.hu \
--to=nm127@freemail.hu \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox